Closed (outdated)
Project:
DrupalCI: Drupal.org Testing Infrastructure
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
24 Mar 2020 at 17:06 UTC
Updated:
21 Dec 2024 at 18:10 UTC
Jump to comment: Most recent
Comments
Comment #2
alexpottYeah this could add it to our package.json. We'll need to do a dependency evaluation in that case.
Comment #3
avpadernoIf it's only required to add a step to validate_codebase, should not it be added to the drupalci.yml file used from Drupal core? Customizing DrupalCI Testing for Projects seems to suggest that is the way to customize tests for a project.I apologize: The documentation shows how to add new steps to the drupalci.yml file, but the dependencies necessary to run those steps need to be installed. This issue is asking to install a NPM package to run cspell together the other tests.
Comment #4
jonathan1055 commentedHasn't this feature already been completed?
I came here looking for how to enable cspell in contrib testing.
Comment #5
avpaderno@jonathan1055 No, it hasn't. Testing a contributed module doesn't run cspell.
Comment #6
jonathan1055 commentedThanks @apaderno. So is this issue all about how to support cspell for contrib module testing? I am sure I have seen it already running on core issue tests on drupal.org.
Comment #7
avpadernoI take this issue is about installing cspell globally and add a new step to the drupalci.yml file used by default. This would allow to run cspell for Drupal core without the changes done on the Drupal core files, and to run cspell for all the contributed modules without committing extra files in their repositories (except the cspell settings files).
Comment #8
drunken monkeySupported since the switch to GitLab CI.