March 30, 2020 - Meeting Agenda [#3121730]

Meeting Agenda

Introductions
Status
Issue updates and discussion
Modification of standard profile for https://www.drupal.org/project/olivero/issues/3123348#comment-13529702

Meeting Details

Time: 2pm UTC (10am Eastern)
‬Meeting Location: #d9-theme channel on drupal.slack.com

Meeting Minutes

Hello, welcome to this week’s Front-end theme Olivero meeting!• This meeting happens every Monday at 2pm GMT (10am ET)• There is no audio or video -- this meeting is chat only• The conversations for this meeting happen in threads0️⃣ If you’re attending this meeting, please let us know here and leave a comment in the meeting agenda issue so we can give you issue credit on d.o.: #3121730: March 30, 2020 - Meeting Agenda

mherchel	:wave: I’m here!
Putra Bonaccorsi	Hello! :wave:
shaal	Hi!
brianperry	Present!
starshaped (she/her)	Hi!
jackh	hello there
thejimbirch	Hi Hi
Neslee	Hi

1️⃣ Status update

mtift (he/him)	Our path to beta is currently headed towards Drupal 9.1: #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta
mherchel	I did a lot of work over the weekend. The majority of it was in #3123305: Grid refactor, where I refactored the grid implementation — making it so that added blocks (where we do not control the markup) inherit the grid system.
mherchel	I went over this with @Putra Bonaccorsi earlier, and hope to merge this shortly.
Putra Bonaccorsi	@mherchel Thanks for putting in time this last weekend! I'm reviewing the patch that you've submitted for the grid refactor work and hopefully we can merge it down soon.
mherchel	I also worked on (and merged) the styling for the administrative tabs in #3122990: Style administrative tabs. I borrowed heavily from Claro’s implementation.
mherchel	In addition, I’ve been making several minor tweaks built on the work that i’ve done (so no patches posted)
Putra Bonaccorsi	I've reviewed and merged down the patch that @kostyashupenko submitted for this issue (https://www.drupal.org/node/3118063). Special shout out to @kostyashupenko for contributing to the many active issues that I have in the project. :clap:
mherchel	I rerolled, reviewed, and requested changes on his patch to #3117242: Theme/style the Form elements
mtift (he/him)	Broadly speaking, where is the most help needed at this point?
mherchel	Currently, there’s a backlog of issues needing review from Putra and I.
mherchel	I’d say in the individual components such as forum, comments, book, etc
jackh	I’m working through the Comments section (and individual comments) #3117242: Theme/style the Form elements
mherchel	Nice! I just re-rolled that patch if you want to pull it down and work on the comments with the patch applied. That issue is getting close
mherchel	and if it takes too long, we may just merge it and open followups (to unblock you and others)
jackh	OK I’ll do that tonight and try to get this thing in a place for review and propose followups.
brianperry	I took a shot at moving #3115190: Configure and theme the Header Region using POC components forward. Posted a patch that enables the system branding block on install and updates header styles to accomodate a site name of varying length. Hopefully not stepping on toes with that one, and fully expect that it will need at least a re-roll with recent changes.
jackh	it’s getting there.
brianperry	Work on the site branding also made it clear that #3115160: Adding additional menu items overlapping with logo will need some re-work. I'll take another look at that.
Neslee	@all I can take up issues :+1:
Neslee	Currently all issues are been assigned to some or the others, waiting for a new issue

2️⃣ Issue updates and status

mtift (he/him)	What issues need some extra attention?
brianperry	Relatively minor, but the main question I had with from work on #3115190: Configure and theme the Header Region using POC components was how to style the site description. Doesn't seem to be represented in the designs.
mherchel	We’re not adding the site description. FYI. I’ll add a comment
mherchel	#3095736: Create content for Drupal's initial "Getting started" page (after minimal or standard profile installation) needs someone to take it and run with it
Putra Bonaccorsi	We need some directions for the following issues.#3117246: Theme Breadcrumbs#comment-13530098
mherchel	That second one is going to be a separate topic during today’s meeting. FYI

3️⃣ Modification of standard profile for #3123348: Create image style and theme hero image for article content types#comment-13529702

mherchel	yeah, so the issue is that we need a new image style for the article’s hero image. We can define this image style in the theme.
mherchel	But we need to set the full display mode to use this. This is where we may need to modify the standard profile.
mherchel	But, we’ll also want to somehow fix this within 8.x. My thought is that we can create a new variable within preprocess that renders the image with the new image style, and then use that.
mherchel	But, I’d love to get any comments or thoughts.
thejimbirch	To me the config would be more user friendly for beginners.
Putra Bonaccorsi	I agree as well. We can add an image style yml to the theme install directory.
thejimbirch	Would the preprocess take over the node display screens in the UI?
Putra Bonaccorsi	However, wouldn't it makes more sense for us to propose a larger image style resizing to be adjusted in the default options? (edited)