CommentFileSizeAuthor
#7 04-view-node.png13.87 KBemptyvoid
#7 03-create-node.png68.49 KBemptyvoid
#7 02-field-settings-token-browser.png107.43 KBemptyvoid
#7 01-field-settings.png69.24 KBemptyvoid
#2 3121613-2.patch388 bytessuresh prabhu parkala

Issue fork field_token_value-3121613

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Suresh Prabhu Parkala created an issue. See original summary.

suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Active » Needs review
StatusFileSize
new 3121613-2.patch388 bytes

Please review!

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Priority: Normal » Critical
Status: Needs review » Reviewed & tested by the community

Looks good
Let's release it

nicoschi’s picture

nicoschi commented

Hi there, any chance to get a new release with this patch included in a way the module is D9 ready and can be installed in an already existing D9 site using composer?

Thanks

emptyvoid’s picture

emptyvoid commented

While having a patch change the info to be D9 compliant.
Is there a set of tests both automated or manual we can run to validate that the core code of this module runs correctly on D9?

emptyvoid’s picture

emptyvoid commented

Running a code compliance pass on the module the following notices are issued:

Check manually
Errors without Drupal source version numbers including parse errors and use of APIs from dependencies.
FILE NAME
web/modules/contrib/field_token_value/src/WrapperManager.php
Line 56
Drupal\field_token_value\WrapperManager must override __construct if using YAML plugins.

web/modules/contrib/field_token_value/field_token_value.info.yml
Line 0
Add core_version_requirement: ^8 || ^9 to designate that the module is compatible with Drupal 9. See https://drupal.org/node/3070687.

Any clue which guides or code references can guide extending or rewriting the plugin registration for the module src?

emptyvoid’s picture

emptyvoid commented
StatusFileSize
new 01-field-settings.png69.24 KB
new 02-field-settings-token-browser.png107.43 KB
new 03-create-node.png68.49 KB
new 04-view-node.png13.87 KB

Hello,

I applied the patch to 8.x-1.x-dev and spun up a fresh Drupal 9 instance.
Installed the module, configured a field, created a node and validated the display.

No errors on install, nor log entries into the system log.

Defining Field Settings
field settings

Viewing Token Browser
field settings

Creating a node with field
creating node

Viewing node with computed field token value
field value

Luckily it does not seem we need to define yaml-based configuration files for the plugin wrapper classes?

So, ready for prime time?

earthday47 made their first commit to this issue’s fork.

steveoriol’s picture

steveoriol
Location Grenoble 🇫🇷
commented

Hello,
can you commit the patch for in the version of dev or create a new version of the module for D9 and higher so that we can install the module via composer.
Thank you.

I tried to install the module by cloning the "https://git.drupalcode.org/issue/field_token_value-3121613.git" inside the module custom folder.
after an: git checkout 3121613-drupal-9-readiness
I can install the module via "admin/modules",
but I do not see any addition "Field value" section to use the token in any of my nodes ??

haydent’s picture

haydent commented
Status: Reviewed & tested by the community » Fixed

Apologies for the delay, I have tagged a new release (2.0.0) which should be compatible with Drupal 9.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.