This is a follow-up to #3073058: Module crashes configuration import. The issue is not fixed yet. I did not have access to reopen that issue so I am opening a new one.

The fix committed in the previous issue is not sufficient as these Bartik blocks get installed from optional too even without Bartik theme enabled, as Bartik is not listed as dependency to those blocks.

To reproduce the issue:

  1. Install Drupal using minimal install profile
  2. Enable private_message
  3. Export configuration
  4. Do a reinstall drush site-install --existing-configuration. This fails.
CommentFileSizeAuthor
#2 3121176-2.patch1.28 KBmikran

Comments

mikran created an issue. See original summary.

mikran’s picture

mikran commented
Status: Active » Needs review
StatusFileSize
new 3121176-2.patch1.28 KB

patch adds bartik as dependency to these blocks

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs review » Reviewed & tested by the community

Yes... the bug and the fix are obvious. When installing the module on a site where Bartik is disabled, the 3 blocks are installed. But they shouldn't be installed, as they're optional and should be installed only if all their dependencies are met.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Title: Module crashes configuration import pt2 » Optional Bartik blocks should depend on Bartik theme
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Priority: Normal » Major

  • anmolgoyal74 committed 9b5bf4c on 8.x-2.x authored by mikran 
    Issue #3121176 by mikran: Optional Bartik blocks should depend on Bartik...
anmolgoyal74’s picture

anmolgoyal74 commented
Status: Reviewed & tested by the community » Fixed

Fixed and Pushed to 8.x-2.x.
Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.