CommentFileSizeAuthor
#6 3121129-6.patch553 bytesmaxpah
#2 3121129-2.patch295 bytessuresh prabhu parkala

Comments

Suresh Prabhu Parkala created an issue. See original summary.

suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Active » Needs review
StatusFileSize
new 3121129-2.patch295 bytes

Please review the patch.

mo_farhaz’s picture

mo_farhaz commented
Status: Needs review » Reviewed & tested by the community

Thanks @suresh.
Patch applied without an issue.

itamair’s picture

itamair commented
Status: Reviewed & tested by the community » Fixed

Committed into dev, will be part of the next release.

maxpah’s picture

maxpah
Primary language French
commented
StatusFileSize
new 3121129-6.patch553 bytes

Hello,

Thanks for the patch, here is a missing part to install this module via composer on Drupal 9 (submodule patch).

itamair’s picture

itamair commented

@MaxPah are you serious? you patch looks doing exactly what the #2 already did ...

maxpah’s picture

maxpah
Primary language French
commented

@itamair I am serious, the first patch attached by Suresh is for geofield_map module but not for geofield_map_extras.

I had to patch for this submodule even after add the old patch from comment 2...

itamair’s picture

itamair commented
Status: Fixed » Needs review

Ah sorry @MaxPah ... thanks for pointing this out.
I didn't know that also submodules need this adaption too.
I am going to review this further ... (thanks for your patch tough!).

  • itamair committed 6aac639 on 8.x-2.x authored by MaxPah 
    Issue #3121129 by Suresh Prabhu Parkala, MaxPah: Compatibility with...
itamair’s picture

itamair commented

Committed into dev will be part of the next release.

maxpah’s picture

maxpah
Primary language French
commented
Status: Needs review » Fixed

Working well ! Thanks for your reactivity

kapilv’s picture

kapilv commented
Issue tags: +Drupal 9 compatibility

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.