Add core_version_requirement: ^8 || ^9 in the info.yml file.

CommentFileSizeAuthor
#10 3121128-10.patch3.08 KBnitesh624
#7 interdiff-2-6.txt2.79 KBsja112
#6 3121128-purge-d8-rediness-6.patch3.08 KBsja112
#6 interdiff-2-6.patch2.79 KBsja112
#3 3121128-3-purge-d8-rediness.patch7.71 KBsushyl
#2 readiness-2.patch295 bytesmithun s

Comments

Mithun S created an issue. See original summary.

mithun s’s picture

mithun s
Primary language English
Location Bangalore
commented
Status: Active » Needs review
StatusFileSize
new readiness-2.patch295 bytes

I have added the patch to the above issue. Please review the patch file.

sushyl’s picture

sushyl
Location Pune
commented
StatusFileSize
new 3121128-3-purge-d8-rediness.patch7.71 KB

Added few more D9 compatibility changes for purge module.

There will be the remaining warnings in purge_drush

And these errors will be fixed here: https://www.drupal.org/project/purge/issues/3087439

2 warnings found.

web/modules/contrib/purge/modules/purge_drush/src/Commands/QueueCommands.php:
-----------------------------------------------------------------
STATUS LINE MESSAGE
-----------------------------------------------------------------
Check 506 Call to deprecated method aliasManager() of class
manually Drush\Drush: Use injected alias manager instead. @see
Drush::drush()
-----------------------------------------------------------------

web/modules/contrib/purge/modules/purge_drush/src/Commands/QueueCommands.php:
-----------------------------------------------------------------
STATUS LINE MESSAGE
-----------------------------------------------------------------
Check 506 Call to deprecated method aliasManager() of class
manually Drush\Drush: Use injected alias manager instead. @see
Drush::drush()
-----------------------------------------------------------------

gaëlg’s picture

gaëlg
he/him
Primary language French
Location Lille, France
commented
Status: Needs review » Needs work

Thank you for your work!

Patch #2 lacks submodules info.yml fixes, but patch #3 contains fixes that conflict with #3087394: Drupal 9 Deprecated Code Report. The scope of this issue should stay limited to info.yml changes to avoid duplicate work.

nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Assigned: Unassigned » nitesh624
Issue tags: +Drupal 9 compatibility
sja112’s picture

sja112 commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2-6.patch2.79 KB
new 3121128-purge-d8-rediness-6.patch3.08 KB

I have updated the patch to include submodules info.yml fixes.

Please review.

sja112’s picture

sja112 commented
StatusFileSize
new interdiff-2-6.txt2.79 KB

Include wrong interdiff file.

The last submitted patch, 6: interdiff-2-6.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 6: 3121128-purge-d8-rediness-6.patch, failed testing. View results

nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
StatusFileSize
new 3121128-10.patch3.08 KB

tests were failed in the commit by the maintainer on 28 Feb 2020 .
Please see https://www.drupal.org/pift-ci-job/1595419 for reference. so tracking tests is out of scope for this ticket.

nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Status: Needs work » Needs review
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Assigned: nitesh624 » Unassigned
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Status: Needs review » Postponed

making this issue to postponed as per https://drupal.slack.com/archives/C1BMUQ9U6/p1589154180059600 and discussion over #contribute slack channel

japerry’s picture

japerry
Location KOMK
commented
Status: Postponed » Closed (duplicate)

duplicate of #3087394: Drupal 9 Deprecated Code Report