Some minor bugs and coding standard

CommentFileSizeAuthor
#13 fix_coding_standard-3121109-13.patch4.08 KBNeeraj333
#10 rerolldiff_5-9.txt39.72 KBayush.khare
#9 rerolldiff_5-9.txt33.81 KBayush.khare
#9 3121109-9.patch43.51 KBayush.khare
#5 3121109-5.patch49.64 KBsuresh prabhu parkala
#4 error-after-apply-patch-ds-3121109.png185.28 KBdharti patel
#2 3121109-2.patch29.97 KBneelam_wadhwani

Comments

neelam_wadhwani created an issue. See original summary.

neelam_wadhwani’s picture

neelam_wadhwani commented
Assigned: neelam_wadhwani » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3121109-2.patch29.97 KB

KIndly review the patch.

dharti patel’s picture

dharti patel commented
Assigned: Unassigned » dharti patel
dharti patel’s picture

dharti patel commented
Assigned: dharti patel » Unassigned
Status: Needs review » Needs work
StatusFileSize
new error-after-apply-patch-ds-3121109.png185.28 KB

Hello @neelam_wadhwani,
I've reviewed the #2 patch but after applying the patch facing the below issue.

Please find attached a screenshot for the error. Need to move in Need to work.

Thanks!

suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Needs work » Needs review
StatusFileSize
new 3121109-5.patch49.64 KB

Update the patch. Please review.

Status: Needs review » Needs work

The last submitted patch, 5: 3121109-5.patch, failed testing. View results

swentel’s picture

swentel commented
Version: 8.x-4.x-dev » 5.0.x-dev
ayush.khare’s picture

ayush.khare commented
Assigned: Unassigned » ayush.khare
ayush.khare’s picture

ayush.khare commented
Assigned: ayush.khare » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3121109-9.patch43.51 KB
new rerolldiff_5-9.txt33.81 KB

Added the reroll for #5 patch.

ayush.khare’s picture

ayush.khare commented
StatusFileSize
new rerolldiff_5-9.txt39.72 KB

Correct re-roll for #9 patch.

swentel’s picture

swentel commented

#2838343: Clean-up codebase according current coding standards is in, there's a big chance this one is probably obsolete now.

swentel’s picture

swentel commented
Status: Needs review » Needs work
Neeraj333’s picture

Neeraj333 commented
Status: Needs work » Needs review
StatusFileSize
new fix_coding_standard-3121109-13.patch4.08 KB

Status: Needs review » Needs work

The last submitted patch, 13: fix_coding_standard-3121109-13.patch, failed testing. View results

swentel’s picture

swentel commented
Version: 5.0.x-dev » 8.x-3.x-dev
swentel’s picture

swentel commented
Status: Needs work » Closed (outdated)

This is actually completely outdated