Problem/Motivation

The various project shows that we never overridden $page-vertical-gap SASS variable and that assumption that this variable should control both header and content bottom margin is probably overly optimistic. Also, we can not by default assume any kind of bottom margin for region_content because of supports of paragraph containers with bg styles - in this case, you do not want some kind of a vertical gap between content and footer.

Proposed resolution

- Remove $page-vertical-gap SASS variable.
- Remove page__header, page__main and region-content elements bottom margin.
- Introduce helper $container-spacer-y and use this value as a default for $region-content-footer-margin. We do this because we need a general variable for this and in the future, we will probably expand usage of this variable.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pivica created an issue. See original summary.

pivica’s picture

Here is a patch.

pivica’s picture

Let's also remove the top margin from region-content-footer because most of the time we apply only bottom border and leave the previous element to decide about spacing.

pivica’s picture

Status: Active » Needs review

  • pivica committed 2c04ea1 on 8.x-1.x
    Issue #3120707 by pivica: Remove $page-vertical-gap SASS variable which...
pivica’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.