Problem/Motivation
The various project shows that we never overridden $page-vertical-gap SASS variable and that assumption that this variable should control both header and content bottom margin is probably overly optimistic. Also, we can not by default assume any kind of bottom margin for region_content because of supports of paragraph containers with bg styles - in this case, you do not want some kind of a vertical gap between content and footer.
Proposed resolution
- Remove $page-vertical-gap SASS variable.
- Remove page__header, page__main and region-content elements bottom margin.
- Introduce helper $container-spacer-y and use this value as a default for $region-content-footer-margin. We do this because we need a general variable for this and in the future, we will probably expand usage of this variable.
Comment | File | Size | Author |
---|---|---|---|
#3 | remove-page-vertical-gap-sass-var-3120707-3.patch | 3.49 KB | pivica |
#3 | interdiff-3120707-2-3.txt | 457 bytes | pivica |
Comments
Comment #2
pivica CreditAttribution: pivica at MD Systems GmbH commentedHere is a patch.
Comment #3
pivica CreditAttribution: pivica at MD Systems GmbH commentedLet's also remove the top margin from region-content-footer because most of the time we apply only bottom border and leave the previous element to decide about spacing.
Comment #4
pivica CreditAttribution: pivica at MD Systems GmbH commentedComment #6
pivica CreditAttribution: pivica at MD Systems GmbH commentedCommitted.