Notice on report page.

Notice: A non well formed numeric value encountered in Drupal\site_audit\Plugin\SiteAuditCheck\CodebaseSizeAll->getResultInfo() (line 43 of modules/contrib/site_audit/src/Plugin/SiteAuditCheck/CodebaseSizeAll.php).

CommentFileSizeAuthor
#4 3120183-4.patch2.03 KBjrglasgow
#2 3120183-2.patch1.09 KBswatichouhan012

Comments

swatichouhan012 created an issue. See original summary.

swatichouhan012’s picture

swatichouhan012 commented
Assigned: swatichouhan012 » Unassigned
Status: Active » Needs review
StatusFileSize
new 3120183-2.patch1.09 KB

i have created a patch to fix notices on report patch, kindly review

jrglasgow’s picture

jrglasgow commented

the problem I see with this is the information being returned is text, in my local it is "443268\t/var/www/docroot", which is the size in bytes and the directory separated by a TAB character, so the check is_numeric() returns FALSE so nothing gets returned.

jrglasgow’s picture

jrglasgow commented
StatusFileSize
new 3120183-4.patch2.03 KB

this patch I think will be a little more resilient

  • jrglasgow committed 6b9d3ee on 8.x-3.x 
    Issue #3120183 by swatichouhan012, jrglasgow: Notice: A non well formed...

  • jrglasgow committed 76ac531 on 8.x-3.x 
    Issue #3120183 by swatichouhan012, jrglasgow: Notice: A non well formed...
jrglasgow’s picture

jrglasgow commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.