Closed (fixed)
Project:
Drupal core
Version:
9.0.x-dev
Component:
mysql db driver
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
16 Mar 2020 at 17:51 UTC
Updated:
31 Mar 2020 at 14:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
effulgentsia commentedComment #3
effulgentsia commented#2's test results are as expected. Passed on MySQL 5.7 and MariaDB 10.3.22, and failed on MariaDB 10.2.7.
Comment #4
daffie commentedThe one blocker for having MariaDB version 10.3 as a minimum has been removed.
Going for 10.3.7, because it is the first GA release is to me also a good idea.
I am for setting the minimum version of PostgreSQL to 10.3.7.
The patch looks good to me and the testbot is happy.
Great to see that it fails for with PostgreSQL 10.2.
Created a followup to remove the testbot with PostgreSQL 10.2. See: #3120197: Remove MariaDB 10.2 because the minimum supported version for Drupal 9.0 will be MariaDB 10.3.
For me it is RTBC.
Comment #5
gábor hojtsyComment #7
catchDiscussed this with xjm last night and we're both OK with raising the version.
As long as we continue to test on MySQL 5.7, raising the MariaDB requirement should make it hard to introduce incompatibilies.
If we do want to take advantage of divergent features, we'll need to have a proper look at how to do that (probably different drivers, but then what about other MySQL-alikes?) - for now this is only about support cycles rather than actual API requirements. @effulgentsia has agreed to make a contrib driver for 10.2
Committed 8dc0353 and pushed to 9.0.x. Thanks!
Comment #8
gábor hojtsyI went to see if there was a MariaDB 10.2.x regular test set up for core, so we should remove it but that does not seem to be the case.
Comment #9
xjmAnd I queued an on-commit test for MariaDB 10.3.7. (The previous item on the QA report was the "run once" from before the separate test environments were added.)
Comment #10
xjmWe'll also want to explain in the release notes that this is different from the MySQL version and we know and we did that on purpose. I'll propose suggestions in the doc since it's in the context of a whole section.