Add the 'core_version_requirement' key in info.yml

Please review the patch.

LGTM.

+++ b/social_auth_google.info.yml
@@ -2,7 +2,7 @@ name: Social Auth Google
-core: 8.x
+core_version_requirement: ^8 || ^9

Since Drupal versions before 8.7.7 need the `core` key in the info file, I think we should not remove that.

updated patch as per comment #4.

Since Drupal versions before 8.7.7 need the `core` key in the info file, I think we should not remove that.

With the release of Drupal 8.9 (and 9.0) yesterday, 8.7 is now EOL and unsupported by the core Drupal team, meaning it no longer receives updates, including security updates.

• https://hugovk.github.io/drupal-release-cycle/
• https://www.drupal.org/core/release-cycle-overview

May I suggest this module also no longer needs to support 8.7?

Also, 8.7.7 was released on 4 September 2019, and the last 8.7.14 on 20 May 2020, so people unable/unwilling to use 8.8/8.9/9.0 have the option of 8.7.8+.

@hugovk, thank you for your valuable feedback, There are confusion over this whether the "core" key should be there along with "core_version_requirement". So in that case i feel patch in comment #2 is fine.
@hussainweb, hope @hugovk answered your concern for core key.

@hugovk, @narendra.rajwar27, you're right. Drupal 8.7 is EOL and I would love it if the module takes a stance and says it won't support. But that should be for more meaningful code where there is value delivered (in terms of new API or removing deprecated API).

It's not worth to break support for removing a harmless line of code. Imagine someone still on Drupal 8.7 or before. This module will suddenly disappear from their extension list just because we didn't remove this line. On the other hand, keeping the line in has no cost to us or to users. It could be removed when Drupal 8.7 is a distant memory.

Last point: The same patch has been submitted by Project updates bot in #3141753: Automated Drupal Rector fixes. You'll notice there that it only adds the new line, doesn't remove the `core: 8.x`.

Thanks for your comments. I am not interested in turning this into a bikeshedding discussion over `core: 8.x` line. I'll let the maintainers decide. I just hope either of these patches is committed soon.

I would love it if the module takes a stance and says it won't support.

@hussainweb, agreed on this note. As for Drupal8 version module support will always there until there is explicitly mentioning.

I think it doesn't hurt to have that extra line, and as mentioned before, the patch produced by the bot does not remove the line. I think we're fine with #5

Sounds sensible, thanks all!

@gvso, thanks for committing this. Are you planning to tag a release with this fix in the near future? I was just thinking if I feel brave enough switching to the dev release. :)

I just created a new release. Thanks everyone!