Overview

The Video Embed Dacast module simply provides a VideoEmbedProvider plugin to integrate Dacast with the Video Embed Field module.

As Dacast does not currently support oEmbed, this module is used for adding videos hosted there to sites.

Dependencies

Project page

https://www.drupal.org/project/video_embed_dacast

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/video_embed_dacast.git

Pareview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-video_embed_da...

Comments

kimberleycgm created an issue. See original summary.

rksyravi’s picture

Issue summary: View changes

Hi @kimberleycgm,

Thank you for contribution!!!

avpaderno’s picture

ankush_03’s picture

@kimberleycgm

You can also add composer.json file in module directory.

kimberleycgm’s picture

avpaderno’s picture

crafter’s picture

It's pretty good for me, maybe one thing I would try to change using static \Drupal::configFactory hereto DI, but I know that it's static method so it's impossible use $this there.
By the way I am curious how is the best way to achieve that if you of course have to use a static method.

klausi’s picture

Status: Needs review » Fixed

Dacast::getIdFromInput(): you need to use preg_quote() for the user provided domain name before using it in the regex.

Otherwise looks good to me.

Thanks for your contribution, Kimberley!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

kimberleycgm’s picture

Thanks @klausi and all other reviewers! I've made that change and now released.

Thanks :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.