Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
7 Mar 2020 at 18:27 UTC
Updated:
6 Apr 2020 at 10:59 UTC
Jump to comment: Most recent
Comments
Comment #2
rksyraviHi @kimberleycgm,
Thank you for contribution!!!
Comment #3
avpadernoComment #4
ankush_03@kimberleycgm
You can also add composer.json file in module directory.
Comment #5
kimberleycgmThanks - composer.json now added https://www.drupal.org/project/video_embed_dacast/issues/3119134
Comment #6
avpadernoComment #7
crafter commentedIt's pretty good for me, maybe one thing I would try to change using static \Drupal::configFactory hereto DI, but I know that it's static method so it's impossible use $this there.
By the way I am curious how is the best way to achieve that if you of course have to use a static method.
Comment #8
klausiDacast::getIdFromInput(): you need to use preg_quote() for the user provided domain name before using it in the regex.
Otherwise looks good to me.
Thanks for your contribution, Kimberley!
I updated your account so you can opt into security advisory coverage now.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #9
kimberleycgmThanks @klausi and all other reviewers! I've made that change and now released.
Thanks :)