Closed (fixed)
Project:
Cloud
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
7 Mar 2020 at 12:29 UTC
Updated:
27 Mar 2020 at 16:54 UTC
Jump to comment: Most recent, Most recent file
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 3118441-11.patch | 88.27 KB | jigish.addweb |
Comments
Comment #2
jigish.addweb commentedComment #3
yas@jigishaddweb
Thank you for adding the feature. Please refactor:
=== TRUE,!==NULL,isset, and so on.?: []toforeachLooks overlapping lots of logic in between Ec2Service and BatchOperations. It should be refactored by another issue.
Comment #4
yasComment #5
jigish.addweb commented@yas
Thank you for testing the patch.
I refactored the code. Please test updated patch.
Thanks
Comment #6
yas@jigishaddweb
Thanks you for the update. Let's reorder the menu tabs
I had the following error in Recent log messages:
Could you please check it?
Comment #7
jigish.addweb commented@yas
Reordered the tab as shown in screenshot. Also, fixed warning.
Please test updated patch.
Thanks
Comment #8
yas@jigishaddweb
Thank you for the update. Please see my comments below:
Comment #9
jigish.addweb commented@yas
I added SecurityGroup link. Attachment is available so we need to keep that fieldset.
Please test updated patch.
Thanks
Comment #10
yas@jigishaddweb
Thank you for the update. I tested and looks good to me now.
I have a question --- can you hide the attachment fieldset if there are no items?
Comment #11
jigish.addweb commented@yas
Thank you for testing the patch.
I hide the Attachment fieldset if there are no items.
Please test new patch file.
Thanks
Comment #12
yas@jigishaddweb
Thank you for the update. The interdiff was helpful. It looks good to me now. I'll merge the patch to
8.x-1.xand8.x-2.xand close this issue asFixed.Comment #15
yasComment #16
yas