CommentFileSizeAuthor
#2 3118211-2.patch12.44 KBjigish.addweb

Comments

jigish.addweb created an issue. See original summary.

jigish.addweb’s picture

Status: Active » Needs review
StatusFileSize
new12.44 KB
yas’s picture

@jigishaddweb

Thank you for the update. Just a quick question, can we try to remove by refactoring the following logic?

      // When the link is clicked, clear out the to and from port.
      // Hide the row, and add a message for the user.
      $.each($('.ip-permission-values .remove-rule', context), function (k, el) {
        $(el).click(function () {
          let row_count = $(this).attr('data-row');
          let table_id = $(this).attr('data-table-id');
          Drupal.SecurityGroup.showHide.hideRow('ip-permission', row_count, table_id);
        });
      });

      $.each($('.outbound-permission-values .remove-rule', context), function (k, el) {
        $(el).click(function () {
          let row_count = $(this).attr('data-row');
          let table_id = $(this).attr('data-table-id');
          Drupal.SecurityGroup.showHide.hideRow('outbound-permission', row_count, table_id);
        });
      });
yas’s picture

yas’s picture

Status: Needs review » Reviewed & tested by the community

@jigishaddweb

Let's merge this patch once and create another issue to fix a bug for Remove links in the SG form.

yas’s picture

Status: Reviewed & tested by the community » Fixed

  • yas committed e99b4c2 on 8.x-1.x authored by jigish.addweb
    Issue #3118211 by jigish.addweb, yas: Remove JavaScript to hide and show...

  • yas committed 4f68d59 on 8.x-2.x authored by jigish.addweb
    Issue #3118211 by jigish.addweb, yas: Remove JavaScript to hide and show...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.