Run against 1c5dfc8.

 ------ ------------------------------------------
  Line   advagg.drush.inc
 ------ ------------------------------------------https://www.drupal.org/sites/all/modules/bueditor/icons/x1.png
  99     Call to deprecated function drush_log().
  109    Call to deprecated function drush_log().
  124    Call to deprecated function drush_log().
  146    Call to deprecated function drush_log().
  160    Call to deprecated function drush_log().
  166    Call to deprecated function drush_log().
 ------ ------------------------------------------

 ------ --------------------------------------------------------------------------
  Line   advagg_validator/src/Form/BaseValidatorForm.php
 ------ --------------------------------------------------------------------------
  289    Call to deprecated function file_stream_wrapper_uri_normalize():
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\StreamWrapper\StreamWrapperManagerInterface::normalizeUri()
         instead.
 ------ --------------------------------------------------------------------------
CommentFileSizeAuthor
#16 3118074-16.patch6.49 KBjedsaet
#9 3118074-8.patch6.61 KBwodzik
#7 3118074-5.patch6.6 KBwodzik
#4 3118074-4.patch3.45 KBShreevasa Tantry
#3 3118074-3.patch2.42 KBShreevasa Tantry

Comments

FatGuyLaughing created an issue. See original summary.

Steven Brown’s picture

Steven Brown commented
Issue summary: View changes
Shreevasa Tantry’s picture

Shreevasa Tantry commented
Status: Active » Needs review
StatusFileSize
new 3118074-3.patch2.42 KB

Please review the patch file.

Shreevasa Tantry’s picture

Shreevasa Tantry commented
StatusFileSize
new 3118074-4.patch3.45 KB

Please review the patch file.

suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Needs review » Reviewed & tested by the community

Patch applied without error.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Please show me the change records of drush_log()

wodzik’s picture

wodzik commented
StatusFileSize
new 3118074-5.patch6.6 KB

Please review the patch file.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: 3118074-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

wodzik’s picture

wodzik commented
StatusFileSize
new 3118074-8.patch6.61 KB
neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs work » Needs review
gambry’s picture

gambry
Primary language Italian
Location Milan
commented
Status: Needs review » Reviewed & tested by the community

@thalles

Please show me the change records of drush_log()

I don't think drush has CRs page like drupal does so in order to find out what is deprecated you need to scan 9.x branch for @deprecated or find a tools that search it against your code usage.

The deprecation for drush_log() is here though.

+++ b/advagg_validator/src/Form/BaseValidatorForm.php
@@ -4,12 +4,44 @@ namespace Drupal\advagg_validator\Form;
+ *

Additional unneeded space in dockblock, but can be fixed on commit.
Also there are other changes which are not D9 related, but they do clean the code a bit so I believe they can go in too.

As any change can be either left or altered on commit I believe this can be RTBC.

kapilv’s picture

kapilv commented
Issue tags: +drush
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Issue tags: -drush

I think we should separate this in other issues, so I will commit part of #9

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

I think #9 needs Reroll!

error: patch failed: advagg.drush.inc:96
error: advagg.drush.inc: patch does not apply
error: patch failed: advagg_mod/src/Form/SettingsForm.php:147
error: advagg_mod/src/Form/SettingsForm.php: patch does not apply
error: patch failed: advagg_validator/src/Form/BaseValidatorForm.php:4
error: advagg_validator/src/Form/BaseValidatorForm.php: patch does not apply
error: patch failed: src/AdvaggSettersTrait.php:72
error: src/AdvaggSettersTrait.php: patch does not apply
error: patch failed: src/Asset/AssetOptimizer.php:13
error: src/Asset/AssetOptimizer.php: patch does not apply
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Reviewed & tested by the community » Needs work
jedsaet’s picture

jedsaet commented
Status: Needs work » Needs review
StatusFileSize
new 3118074-16.patch6.49 KB

#9 rerolled.

  • thalles committed cbeb85a on 8.x-4.x authored by jedsaet 
    Issue #3118074 by Shreevasa Tantry, wodzik, jedsaet, thalles,...
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Issue summary: View changes

Apparently, in this issue, we should correct only the depreciation of the drush_log function, other issues are out of scope.

Thanks all!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs review » Fixed

I created another issues to each diferent question

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.