CommentFileSizeAuthor
#41 before patch.png26.45 KBprem suthar
#41 after Patch.png31.9 KBprem suthar
#39 3117860-39.patch950 bytesakram khan
#38 3117860-38.patch957 bytesakram khan
#30 interdiff-20_30.txt768 bytesgauravvvv
#30 3117860-30.patch981 bytesgauravvvv
#29 After Patch 3117860.png151.86 KBchetanbharambe
#29 Before Patch 3117860 up.png158.15 KBchetanbharambe
#29 Before Patch 3117860.png303.68 KBchetanbharambe
#25 after_patch_20.jpeg37.28 KBambuj_gupta
#25 before_patch_20.jpeg34.97 KBambuj_gupta
#20 3117860-add-a-permission.patch965 bytesricha_porwal
#18 3117860-add-a-permission.patch993 bytesricha_porwal
#16 Patch Fail 3117860.png605.44 KBchetanbharambe
#13 Patch_apply_error_2.png76.01 KBvikashsoni
#13 Patch_apply_error_1.png76.78 KBvikashsoni
#8 3117860-7.patch7.7 KBrokzabukovec
#8 interdiff_3117860_7-6.txt6.16 KBrokzabukovec
#6 3117860-6.patch3.64 KBrokzabukovec

Comments

adriancid created an issue. See original summary.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented

@adriancid, we need to have configuration form for this?
In which we have to have a checkbox , on click of it we will disable "Manage" for non-admin roles.

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented

@Neslee Canil Pinto I think the idea here is to have new permission, I don't remember the issue where we talked about this and I see now I forgot to link it. I will see if I can find it.

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented

#3091968: Do not show Search if user does not have the correct permission

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented

Is this as been already fixed?

rokzabukovec’s picture

rokzabukovec commented
Status: Active » Needs review
StatusFileSize
new 3117860-6.patch3.64 KB

I created the patch that adds a 'Use Admin Toolbar manage' permission and hides the 'Manage' menu tab based on that permission. I also added some tests that check the presence of that menu element.
My patch does not prevent the user to go to the URLs from the menu, because the issue does not state that this is necessary. It just hides the menu navigation. If any modifications are required let me know.
Best regards

Status: Needs review » Needs work

The last submitted patch, 6: 3117860-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

rokzabukovec’s picture

rokzabukovec commented
Status: Needs work » Needs review
StatusFileSize
new interdiff_3117860_7-6.txt6.16 KB
new 3117860-7.patch7.7 KB

I fixed the test errors and some coding standards. See the interdiff for changes.
@adriancid can you review it?
Best regards

romainj’s picture

romainj commented

I think that as the Manage menu item is defined by the core Toolbar module this issue should not be related to the Admin Toolbar module.

romainj’s picture

romainj commented
Project: Admin Toolbar » Drupal core
Version: 8.x-2.x-dev » 8.9.x-dev
Component: User interface » toolbar.module
tripurari’s picture

tripurari commented

Reviewing and will update the status shortly.

tripurari’s picture

tripurari commented

I agree with @romainj, permission is already added for toolbar to handle for non-admin-user. It shows Manage if allowed permission to non-admin-user.I think if we allow only toolbar permission to a user, in that case Manage menu should be hidden. In case of adding more permission to non-admin-user like add manage some admin level menu, manage should be visible.

vikashsoni’s picture

vikashsoni commented
StatusFileSize
new Patch_apply_error_1.png76.78 KB
new Patch_apply_error_2.png76.01 KB

#8, #6 Patch is not working sharing screenshot

manojithape’s picture

manojithape commented
Assigned: Unassigned » manojithape
manojithape’s picture

manojithape commented
Assigned: manojithape » Unassigned
chetanbharambe’s picture

chetanbharambe commented
Status: Needs review » Needs work
StatusFileSize
new Patch Fail 3117860.png605.44 KB

Verified and tested patch #8 but it's not applied successfully.
Not working as expected.

Please check the attached screenshot.
Moving to Needs Work.

richa_porwal’s picture

richa_porwal commented
Assigned: Unassigned » richa_porwal
richa_porwal’s picture

richa_porwal commented
StatusFileSize
new 3117860-add-a-permission.patch993 bytes

Hi Team,

I have created patch for the above problem motivation. Need review.

richa_porwal’s picture

richa_porwal commented
richa_porwal’s picture

richa_porwal commented
StatusFileSize
new 3117860-add-a-permission.patch965 bytes

Hi Team,

Please use the latest created patch. Need Review

richa_porwal’s picture

richa_porwal commented
Assigned: richa_porwal » Unassigned
Status: Needs work » Needs review
manojithape’s picture

manojithape commented
Assigned: Unassigned » manojithape
manojithape’s picture

manojithape commented
Assigned: manojithape » Unassigned

Not able to reproduce this issue.

ambuj_gupta’s picture

ambuj_gupta commented
Assigned: Unassigned » ambuj_gupta
ambuj_gupta’s picture

ambuj_gupta commented
StatusFileSize
new before_patch_20.jpeg34.97 KB
new after_patch_20.jpeg37.28 KB

Testing Steps:
1. Install Drupal 8.9.x
2. log in as an admin.
3. Go to "/admin/people/permissions"
4. And Enable toolbar for Non-Admin Roles.
5. Now create an account with a non-admin role
6. And login with that user.
7. And verify the toolbar.
8. Manage option is coming in the toolbar for non-admin users.(issue Replicate)
9. Now apply patch #20.
10. Verify the toolbar (Issue fixed)

Testing Results:
After applying the patch successfully. The Manage option is hidden from the toolbar for the non-admin user

Note:
When the patch is applied successfully, new permission(Use toolbar manage tab) is added into the toolbar option at "/admin/people/permissions". Using which admin is able to show/hide the manage tab for non-admin users.

ambuj_gupta’s picture

ambuj_gupta commented
Assigned: ambuj_gupta » Unassigned
Status: Needs review » Reviewed & tested by the community
quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs issue summary update

This needs an issue summary update, see Write an issue summary for an existing issue for guidance.

chetanbharambe’s picture

chetanbharambe commented
Issue summary: View changes
chetanbharambe’s picture

chetanbharambe commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new Before Patch 3117860.png303.68 KB
new Before Patch 3117860 up.png158.15 KB
new After Patch 3117860.png151.86 KB

Verified and tested patch #20.
Patch applied successfully and looks good to me.

Testing Steps:
# log in as an admin.
# Goto:- /admin/people/permissions
# And Enable toolbar for Non-Admin Roles.
# Now create an account with a non-admin role
# And login with that user.
# And verify the toolbar.
# Manage option is coming in the toolbar for non-admin users.
# Verify the toolbar

Expected Results:
# Menu item ‘Manage’ should be removed for non-admin roles.

Actual Results:
# Currently Menu item 'Manage' is visible for non-admin roles.

Looks good to me.
Can be a move to +1RTBC.

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 3117860-30.patch981 bytes
new interdiff-20_30.txt768 bytes

Fixed MARKED SNIFF VIOLATIONS, for patch #20, Attached interdiff for same.
please review.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 8.9.x-dev » 9.2.x-dev

Drupal 8.9.x is now open only to security issues.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.1.10 (June 4, 2021) and Drupal 9.2.10 (November 24, 2021) were the last bugfix releases of those minor version series. Drupal 9 bug reports should be targeted for the 9.3.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

dww’s picture

dww
we/he/they
commented

Is this duplicate with #2135445: Toolbar displays Manage tab even if the user is not permitted to see it?

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

igork96’s picture

igork96 commented
Status: Needs review » Reviewed & tested by the community

I tested this and can confirm that patch from #30 is working with the Drupal 9.4.x version

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

#30 doesn't pass tests and we still need an answer to #33.

igork96’s picture

igork96 commented

@catch I checked the issue, and yes I think it is a duplicate. There the best suggestion is to add a new permission for this to access administration pages, with an update function that grants that permission to all roles that are allowed to use the toolbar but don't have the administration pages permission. Maybe we should close this ticket and move further work there ?

akram khan’s picture

akram khan
Primary language English
Location Cuttack, Odisha
commented
StatusFileSize
new 3117860-38.patch957 bytes

updating patch against 9.4.x

akram khan’s picture

akram khan
Primary language English
Location Cuttack, Odisha
commented
StatusFileSize
new 3117860-39.patch950 bytes

Fixing Custom Command failed

prem suthar’s picture

prem suthar commented

#39 Working Fine For me I tested the patch it updated the Permission Form "Use the toolbar "To "Use toolbar manage tab" in toolbar manage.
As mentioned in #37 Please Add new permission for this to access administration pages.

prem suthar’s picture

prem suthar commented
StatusFileSize
new after Patch.png31.9 KB
new before patch.png26.45 KB

Add the screenshot For Refernace.

quietone’s picture

quietone commented

@Akram Khan, @Prem Suthar, thank you for your interest in improving Drupal. The comment in #37 suggests that this is a duplicate. That means the next task here is to read this issue and the other one (See #33) to confirm that. Adding patches or screenshots after that comment aren't helping to resolve the issue. You can use the contributor tasks on Drupal.org that provide the steps for making useful additions to an issue. Credit has been removed per How is credit granted for Drupal core issues.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Needs work » Postponed

The Toolbar Module was approved for removal in #3476882: [Policy] Move Toolbar module to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3484850: [meta] Tasks to deprecate Toolbar module and the removal work in #3488828: [meta] Tasks to remove Toolbar module.

Toolbar will be moved to a contributed project before Drupal 12.0.0 is released.