The config for embed.button.media_directories.yml has dependencies on media types such as remote_video. For profiles such as Lightning, this prevents enabling media_directories_editor since remote_video doesn't exist.

embed.button.media_directories (media.type.remote_video)

CommentFileSizeAuthor
#11 3117564-remove_media_type_dependencies-11.patch2.47 KBytsurk
#10 3117564-remove_media_type_dependencies-10.patch2.57 KBytsurk
#4 3117564-remove-media-type-dependencies.patch1010 bytescainaru
#3 Screen Shot 2020-03-03 at 3.31.38 PM.png361.84 KBcainaru
Screen Shot 2020-03-03 at 3.31.38 PM.png473.25 KBcainaru

Comments

cainaru created an issue. See original summary.

cainaru’s picture

cainaru
she/her
Primary language English
Location Norwood, NY, USA
commented
cainaru’s picture

cainaru
she/her
Primary language English
Location Norwood, NY, USA
commented
Issue summary: View changes
StatusFileSize
new Screen Shot 2020-03-03 at 3.31.38 PM.png361.84 KB
cainaru’s picture

cainaru
she/her
Primary language English
Location Norwood, NY, USA
commented
StatusFileSize
new 3117564-remove-media-type-dependencies.patch1010 bytes

Adding a patch that removes the dependencies on the image and remote_video media types as well as removing the dependency on the full view mode in order to ensure media_directories_editor can be enabled on sites that may not have these media types and/or view modes.

ytsurk’s picture

ytsurk
Location Switzerland
commented
Related issues: +#3111907: Editor button config should be optional

Thanks for the patch. I think this also solves #3111907: Editor button config should be optional

ytsurk’s picture

ytsurk
Location Switzerland
commented
Status: Active » Needs review
rang501’s picture

rang501 commented
Status: Needs review » Reviewed & tested by the community

It seems fine to me, although we need to make sure there is documentation available on how to configure embed button(s).

ytsurk’s picture

ytsurk
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs work

I want to have the two media types and the view created in the install_hook if they exists. So standard users do not need to configure themself.

ytsurk’s picture

ytsurk
Location Switzerland
commented
Assigned: Unassigned » ytsurk
ytsurk’s picture

ytsurk
Location Switzerland
commented
Assigned: ytsurk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3117564-remove_media_type_dependencies-10.patch2.57 KB

So here the final patch. Having the config non-optional installs the button always. The install_hook checks for existing media types and view mode, and installs them if available.

ytsurk’s picture

ytsurk
Location Switzerland
commented
StatusFileSize
new 3117564-remove_media_type_dependencies-11.patch2.47 KB

Removed the check for the config module.

rang501’s picture

rang501 commented
Status: Needs review » Reviewed & tested by the community

It seems fine to me - installed the media_directories_editor module and two media types (image, remote_video) were enabled with two display plugins (full content and image with dimensions).

ytsurk’s picture

ytsurk
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

  • ytsurk committed 67c3f93 on 8.x-1.x 
    Issue #3117564 by ytsurk, cainaru, rang501: Remove media type...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.