Editor button config should be optional [#3111907]

Currently, the embed config prevents media_directories_editor module to be installed if trying to do site install, because it depends on media types but these don't exist by the time it tries to install it.

Comment	File	Size	Author
	media_directories_editor_button_optional.patch	393 bytes	rang501

Comments

Comment #1

7 February 2020 at 12:36

rang501 created an issue. See original summary.

Comment #2

ytsurk

Switzerland

commented 15 February 2020 at 22:23

Status:

Needs review

» Postponed (maintainer needs more info)

How to reproduce this?

I tried drush si, and drush en media_directories_editor (on 8.8.2) - and all worked fine ..

Also, I would not make the config optional. The module shall not be enabled, when it gets enabled the button should be made.
If we cannot make the button, we should check via hook_requirements, so users to necessary steps first to finally successfully install the editor sub-module ...

Comment #3

rang501 commented 17 February 2020 at 21:06

I had a problem with site install when using a custom profile that didn't install media types (config inside submodule). Maybe something to do with dependencies.
It does work with the Standard profile.

Maybe this config should be created programmatically on module install, we could then check if standard media types are available or not? If not available, notify user about it.