Problem/Motivation
We still trying to run Simpletests but there are none. This results in run warnings in test logs.
Proposed resolution
Let's not do the unnecessary work.
Remaining tasks
User interface changes
None
API changes
None
Data model changes
None
Release notes snippet
None
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 3117421-9.patch | 521 bytes | swatichouhan012 |
| #2 | 3117421-2.patch | 521 bytes | alexpott |
Comments
Comment #2
alexpottI wondered if we should comment out the section instead of removing it but really I think don't want people using Simpletest so why advertise it.
Comment #3
mile23Contrib can add it back in their own drupalci.yml if they need to.
Comment #4
mile23Comment #5
lendudeAs discussed on slack, if we do this we probably need to update https://www.drupal.org/node/3112907 to provide a full working example of drupalci.yml instead of just one extra line, which would not be accurate anymore (at least not for people without a drupalci.yml to begin with).
Comment #6
alexpottI’ve updated https://www.drupal.org/node/3112907 and provided step by step instructions and a drupalci.yml file for people to use. Since people need a custom drupalci.yml file anyway I don't think the updates need to wait for this to land. But actually the other way around. Now we're providing a complete drupalci.yml for them we're good to go here.
Comment #8
swatichouhan012 commentedComment #9
swatichouhan012 commentedRe-rolled patch to test pass.
Comment #10
alexpott@swatichouhan012 there was no need to re-roll the patch - the test fail was unrelated - there's a retest button. The rtbc in #4 still counts.
Comment #13
xjmAttached this to the SimpleTest CR:
We should also fold into the release note about SimpleTest the information that core will no longer try to run them, and see the CR for how contrib can run them.
Farewell, SimpleTest echoes.
Comment #14
pameeela commented@alexpott can you update the IS with a release note snippet?
Comment #15
alexpottI've updated the release note on #3075490: Move simpletest module to contrib as that was the issue that actually removed the functionality. This issue only stopped DrupalCI from trying to do something it couldn't possibly do (because SimpleTest is not longer in core).