Problem/Motivation

We still trying to run Simpletests but there are none. This results in run warnings in test logs.

Proposed resolution

Let's not do the unnecessary work.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

CommentFileSizeAuthor
#9 3117421-9.patch521 bytesswatichouhan012
#2 3117421-2.patch521 bytesalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

Status: Active » Needs review
StatusFileSize
new521 bytes

I wondered if we should comment out the section instead of removing it but really I think don't want people using Simpletest so why advertise it.

mile23’s picture

Contrib can add it back in their own drupalci.yml if they need to.

mile23’s picture

Status: Needs review » Reviewed & tested by the community
lendude’s picture

As discussed on slack, if we do this we probably need to update https://www.drupal.org/node/3112907 to provide a full working example of drupalci.yml instead of just one extra line, which would not be accurate anymore (at least not for people without a drupalci.yml to begin with).

alexpott’s picture

I’ve updated https://www.drupal.org/node/3112907 and provided step by step instructions and a drupalci.yml file for people to use. Since people need a custom drupalci.yml file anyway I don't think the updates need to wait for this to land. But actually the other way around. Now we're providing a complete drupalci.yml for them we're good to go here.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3117421-2.patch, failed testing. View results

swatichouhan012’s picture

Assigned: Unassigned » swatichouhan012
swatichouhan012’s picture

Assigned: swatichouhan012 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new521 bytes

Re-rolled patch to test pass.

alexpott’s picture

Status: Needs review » Reviewed & tested by the community

@swatichouhan012 there was no need to re-roll the patch - the test fail was unrelated - there's a retest button. The rtbc in #4 still counts.

  • xjm committed a77f8eb on 9.1.x
    Issue #3117421 by alexpott, swatichouhan012, Mile23, Lendude: Stop...

  • xjm committed 66bb5a7 on 9.0.x
    Issue #3117421 by alexpott, swatichouhan012, Mile23, Lendude: Stop...
xjm’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +9.0.0 release notes

Attached this to the SimpleTest CR:

We should also fold into the release note about SimpleTest the information that core will no longer try to run them, and see the CR for how contrib can run them.

Farewell, SimpleTest echoes.

pameeela’s picture

@alexpott can you update the IS with a release note snippet?

alexpott’s picture

Issue tags: -9.0.0 release notes

I've updated the release note on #3075490: Move simpletest module to contrib as that was the issue that actually removed the functionality. This issue only stopped DrupalCI from trying to do something it couldn't possibly do (because SimpleTest is not longer in core).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.