If @codingStandardsIgnoreFile is removed from the jsminplus.inc file then we can find below warning using php compatibility test

/bin/phpcs --standard=PHPCompatibility --extensions=php,inc,module,install,test,profile,theme --runtime-set testVersion 7.3 path/to/file

FILE: ...standard/modules/contrib/advagg/advagg_js_compress/jsminplus.inc
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
1822 | WARNING | Since PHP 7.0, functions inspecting arguments, like
| | func_get_args(), no longer report the original
| | value as passed to a parameter, but will instead
| | provide the current value. The parameter "$t" was
| | used, and possibly changed (by reference), on line
| | 1809.
----------------------------------------------------------------------

CommentFileSizeAuthor
#2 php7_compatibility-3116299-2.patch678 bytesandras_szilagyi

Comments

Andras_Szilagyi created an issue. See original summary.

andras_szilagyi’s picture

Status: Active » Needs review
StatusFileSize
new678 bytes

this patch solves the issue for me

joelpittet’s picture

Status: Needs review » Reviewed & tested by the community

Nice, had a look and have seen many of these in different queues, that fix looks correct.

thalles’s picture

Thanks @all!

thalles’s picture

Status: Reviewed & tested by the community » Fixed
thalles’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.