Problem/Motivation

When closing the colorbox modal, the width of the slick images gets recalculated wrongly and the slick looks broken. This happens on Firefox and IE.

Proposed resolution

Fix slick slide's width after closing colorbox modal.

CommentFileSizeAuthor
#2 3116234-firefox-ie-width-recalculation-fix.patch2.35 KBsasanikolic
Slick slider broken after closing colorbox.png869.15 KBsasanikolic

Comments

sasanikolic created an issue. See original summary.

sasanikolic’s picture

sasanikolic commented
Status: Active » Needs review
StatusFileSize
new 3116234-firefox-ie-width-recalculation-fix.patch2.35 KB

I think calling $slider.slick('refresh'); is enough to fix this.

gausarts’s picture

gausarts commented
Category: Bug report » Task

Good idea, thank you!

I wonder if we can also remove the setPosition hack up above your line given your fix?
I haven't been able to verify your fix with this Colorbox issue, but I know it works at Slick Browser for few Slick issues.

Changing this to Task since the integration is optional. Nothing bugs this module when being optional, even if you uninstall Colorbox.

sasanikolic’s picture

sasanikolic commented

Hi @gausarts, I tried removing the setPosition hacks above, but that didn't work as expected. That said, could you please test this when possible so we can move forward? :)

gausarts’s picture

gausarts commented

I'll see to it whenever I can, but not today, thanks!

  • gausarts committed 0a9bfde on 8.x-2.x authored by sasanikolic 
    Issue #3116234 by sasanikolic: Width recalculation issue after closing...
gausarts’s picture

gausarts commented
Assigned: sasanikolic » Unassigned
Status: Needs review » Fixed

I guess this is the best love we can give by now for the ancient Colorbox.
All the necessary warnings have been provided in the docs under TROUBLESHOOTING to save anyone time.

Committed. Thank you for contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.