Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
When closing the colorbox modal, the width of the slick images gets recalculated wrongly and the slick looks broken. This happens on Firefox and IE.
Proposed resolution
Fix slick slide's width after closing colorbox modal.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3116234-firefox-ie-width-recalculation-fix.patch | 2.35 KB | sasanikolic |
| |||
| Slick slider broken after closing colorbox.png | 869.15 KB | sasanikolic | |
Comments
Comment #2
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedI think calling
$slider.slick('refresh');is enough to fix this.Comment #3
gausarts CreditAttribution: gausarts commentedGood idea, thank you!
I wonder if we can also remove the
setPositionhack up above your line given your fix?I haven't been able to verify your fix with this Colorbox issue, but I know it works at Slick Browser for few Slick issues.
Changing this to Task since the integration is optional. Nothing bugs this module when being optional, even if you uninstall Colorbox.
Comment #4
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedHi @gausarts, I tried removing the setPosition hacks above, but that didn't work as expected. That said, could you please test this when possible so we can move forward? :)
Comment #5
gausarts CreditAttribution: gausarts commentedI'll see to it whenever I can, but not today, thanks!
Comment #7
gausarts CreditAttribution: gausarts commentedI guess this is the best love we can give by now for the ancient Colorbox.
All the necessary warnings have been provided in the docs under TROUBLESHOOTING to save anyone time.
Committed. Thank you for contribution!