To make it easier for people installing this module to understand what they need to do to get the module to work. There is a README for 7.x, but not 8.x, so I'm essentially just copying that file over in the patch to come.

CommentFileSizeAuthor
#7 interdiff.txt615 bytespratik_kamble
#7 3116025-7.patch1.47 KBpratik_kamble
#5 3116025-5.patch1.47 KBbdlangton
#5 interdiff-3116025-4-5.txt242 bytesbdlangton
#4 3116025-4.patch1.54 KBWebbeh
#4 interdiff-3116025-2-4.txt2.48 KBWebbeh
#2 3116025-2-views_complex_grouping-readme.patch1.08 KBbdlangton

Comments

bdlangton created an issue. See original summary.

bdlangton’s picture

bdlangton commented
Status: Active » Needs review
StatusFileSize
new 3116025-2-views_complex_grouping-readme.patch1.08 KB

Here is the patch.

Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
commented
Component: Code » Documentation
Category: Feature request » Task
Status: Needs review » Needs work

#2 does not meet best-practices of https://www.drupal.org/docs/develop/documenting-your-project/readme-temp... . Marking Needs Work.

Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-3116025-2-4.txt2.48 KB
new 3116025-4.patch1.54 KB
bdlangton’s picture

bdlangton commented
StatusFileSize
new interdiff-3116025-4-5.txt242 bytes
new 3116025-5.patch1.47 KB

Webbeh, thanks for the catch on the README best practices. It looks good, but just removed the sections in the TOC that don't exist.

Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
commented
Status: Needs review » Reviewed & tested by the community

Good catch. Looks good to me.

Rolling to RTBC.

pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
StatusFileSize
new 3116025-7.patch1.47 KB
new interdiff.txt615 bytes

@bdlangton and @Webbeh, Thanks for the patch it LGMT. Just one minor change.

pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.