Problem/Motivation
As part of making this module ready for Drupal 9, we should add a missing core_version_requirement key to the module info file.
see https://www.drupal.org/node/3070687

CommentFileSizeAuthor
#9 3115890-9.patch819 bytesbgilhome
#8 interdiff-7-8.txt692 bytesbgilhome
#8 3115890-8.patch1.07 KBbgilhome
#7 interdiff_2-7.txt403 bytessuresh prabhu parkala
#7 3115890-7.patch765 bytessuresh prabhu parkala
#2 3115890-2.patch306 bytesankush_03

Issue fork value-3115890

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ankushgautam76@gmail.com created an issue. See original summary.

ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
Status: Active » Needs review
Issue tags: +Drupal 9 compatibility
StatusFileSize
new 3115890-2.patch306 bytes

Added patch for the same !

john cook’s picture

john cook commented
Status: Needs review » Reviewed & tested by the community

This looks good.
The patch add changes the core_version_requirement key to the info.yml file.
The patch applies cleanly.

So, I'm changing the status to RTBC.

jsst made their first commit to this issue’s fork.

jsst’s picture

jsst commented

Created an issue fork, didn't mean to, I didn't push anything.

Could we merge this change and publish a new D9 compatible version? Or is there any work that needs to be done?

jsst’s picture

jsst commented
Status: Reviewed & tested by the community » Needs work

The value.services.yml file references the deprecated (removed in D9) entity.manager service. It must be removed for this module to actually work in D9:

-  serializer.value.content_entity:
-    class: Drupal\value\Normalizer\ContentEntityNormalizer
-    tags:
-      - { name: normalizer, priority: 10 }
-    arguments: ['@entity.manager']
suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Needs work » Needs review
StatusFileSize
new 3115890-7.patch765 bytes
new interdiff_2-7.txt403 bytes

Updated patch as per #6 . please review.

bgilhome’s picture

bgilhome commented
StatusFileSize
new 3115890-8.patch1.07 KB
new interdiff-7-8.txt692 bytes

In 9.19, the serializer.normalizer.entity service has 3 arguments - this module's serializer.value.content_entity service only has one. Patch to add the 2 other required arguments (entity_type.repository, entity_field.manager) attached.

bgilhome’s picture

bgilhome commented
StatusFileSize
new 3115890-9.patch819 bytes

Oops, removing the diff on the generated PATCHES.txt file.

arshadcn opened merge request !1

shadcn’s picture

shadcn commented
Status: Needs review » Fixed

@everyone, I had already start fixing D9 deprecated code when I saw this issue. Sorry. I'll keep the issue credit. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.