CommentFileSizeAuthor
#26 3115345-nr-bot.txt144 bytesneeds-review-queue-bot
#20 interdiff_14-20.txt1.66 KBpradeepjha
#20 3115345-20.patch10.3 KBpradeepjha
#17 interdiff_14-17.txt878 bytespradeepjha
#17 3115345-17.patch10.3 KBpradeepjha
#14 interdiff_12-14.txt2.33 KBnarendra.rajwar27
#14 3115345-14.patch10.15 KBnarendra.rajwar27
#12 3115345-13.patch7.99 KBkishor_kolekar
#9 interdiff-7-9.txt3.54 KBhardik_patel_12
#9 3115345-9.patch8.53 KBhardik_patel_12
#7 interdiff-5-7.txt985 byteshardik_patel_12
#7 3115345-7.patch5.23 KBhardik_patel_12
#5 interdiff-2-5.txt580 byteshardik_patel_12
#5 3115345-5.patch4.3 KBhardik_patel_12
#2 3115345-2.patch3.77 KBhardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3115345-2.patch3.77 KB

Kindly review a patch. Deleting views-ui-views-listing-table.html.twig dile from Claro and stable theme.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 3115345-2.patch, failed testing. View results

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs work » Needs review
StatusFileSize
new 3115345-5.patch4.3 KB
new interdiff-2-5.txt580 bytes

Kindly review a new patch.

Status: Needs review » Needs work

The last submitted patch, 5: 3115345-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs work » Needs review
StatusFileSize
new 3115345-7.patch5.23 KB
new interdiff-5-7.txt985 bytes

Kindly review a new patch.

Status: Needs review » Needs work

The last submitted patch, 7: 3115345-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Needs work » Needs review
StatusFileSize
new 3115345-9.patch8.53 KB
new interdiff-7-9.txt3.54 KB

Kindly review a new patch.

Status: Needs review » Needs work

The last submitted patch, 9: 3115345-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

kishor_kolekar’s picture

kishor_kolekar commented
Status: Needs work » Needs review
StatusFileSize
new 3115345-13.patch7.99 KB

I've re-rolled patch for 9.1

Status: Needs review » Needs work

The last submitted patch, 12: 3115345-13.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language Hindi
Location India
commented
Status: Needs work » Needs review
StatusFileSize
new 3115345-14.patch10.15 KB
new interdiff_12-14.txt2.33 KB

Fix added for failed test cases.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

This issue needs the summary to be updated so others can understand why this task needs to be done.

  1. +++ b/core/themes/classy/css/components/image-widget.css
@@ -10,8 +10,6 @@
  *

+++ b/core/themes/seven/css/classy/components/image-widget.css
@@ -10,8 +10,6 @@
  *

    Extra blank lines remaining at the end of these comment blocks. 

  2. +++ b/core/tests/Drupal/Tests/Core/Theme/ClassyPreprocessUnchangedTest.php
@@ -22,7 +22,7 @@ class ClassyPreprocessUnchangedTest extends UnitTestCase {
-    $this->assertSame($hash, 'c42ff3a1291a258b42f0c44010cd28c7', "The file hash for classy.theme has changed. Any additions or changes to preprocess functions should be added to the themes that inherit Classy. \nIf the changes to classy.theme are not changes to preprocess functions, update the hash in this test to: '$hash' so it will pass.");
+    $this->assertSame($hash, 'd1f97be7ae2d99652d216d4773d09bf5', "The file hash for classy.theme has changed. Any additions or changes to preprocess functions should be added to the themes that inherit Classy. \nIf the changes to classy.theme are not changes to preprocess functions, update the hash in this test to: '$hash' so it will pass.");

    We are changing the hash because of a change to the preprocess function, which the message explicitly warns against. Does this mean we are doing something wrong here?

pradeepjha’s picture

pradeepjha commented
Assigned: Unassigned » pradeepjha
pradeepjha’s picture

pradeepjha commented
Assigned: pradeepjha » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3115345-17.patch10.3 KB
new interdiff_14-17.txt878 bytes

Hi @longwave,

Extra blank lines remaining at the end of these comment blocks.

- Removed now.

We are changing the hash because of a change to the preprocess function, which the message explicitly warns against. Does this mean we are doing something wrong here?

- If we make any change in template, in that case this hash code is changing. That's why we used to update the hash code in test case.

Status: Needs review » Needs work

The last submitted patch, 17: 3115345-17.patch, failed testing. View results

pradeepjha’s picture

pradeepjha commented
Assigned: Unassigned » pradeepjha
pradeepjha’s picture

pradeepjha commented
Assigned: pradeepjha » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3115345-20.patch10.3 KB
new interdiff_14-20.txt1.66 KB

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3115345-nr-bot.txt144 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.