FILE: /var/www/html/drupal_contrib/web/modules/contrib/instagram_graph/src/Controller/OAuthController.php
---------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------
78 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
84 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal_contrib/web/modules/contrib/instagram_graph/src/Image.php
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
60 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#4 3115079-4.patch4.53 KBsanterref
#3 3115079-3.patch4.11 KBswatichouhan012

Comments

swatichouhan012 created an issue. See original summary.

ravi.shankar’s picture

ravi.shankar commented
Issue summary: View changes
Status: Needs work » Active
swatichouhan012’s picture

swatichouhan012 commented
Assigned: swatichouhan012 » Unassigned
Status: Active » Needs review
StatusFileSize
new 3115079-3.patch4.11 KB

I have created patch to use dependency injection in classes, kindly review.

santerref’s picture

santerref commented
Assigned: Unassigned » santerref
Status: Needs review » Needs work
StatusFileSize
new 3115079-4.patch4.53 KB

Hi @swatichouhan012 !

Thanks for your patch #3

There was a little error on line 48 (unwanted comma) and the new entity_type.manager service was not added to the services.yml file.

santerref’s picture

santerref commented
Status: Needs work » Fixed
santerref’s picture

santerref commented
Status: Fixed » Closed (fixed)

Added to alpha2 release.