There are two alert calls in formatters/tabs/horizontal-tabs.js that should probably be removed or commented out. I noticed one of them when a required field (in a horizontal tab) validator was triggered.

CommentFileSizeAuthor
#3 remove-alerts-3114619-2.patch832 bytesmekal

Comments

mekal created an issue. See original summary.

mekal’s picture

mekal commented
mekal’s picture

mekal commented
StatusFileSize
new remove-alerts-3114619-2.patch832 bytes

I've never submitted a patch before so not sure if this is 100% right...hopefully its at least helpful.

bartlangelaan’s picture

bartlangelaan
Primary language Dutch
Location Netherlands
commented
Status: Active » Reviewed & tested by the community

Looks like some debug code that was introduced in #3044595: Field groups are not displayed in layout builder block config forms (alerts aren't there in the latest patch, but they are in the commit).

Can't find any other alerts in the codebase.

Patch looks good!

nils.destoop’s picture

nils.destoop commented
Status: Reviewed & tested by the community » Fixed

Thx for noticing this. I committed the patch to dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.