Add a menu when the Cloud module is installed

@jigish,

I reviewed the patch and have the following comments.

1. +++ b/src/EventSubscriber/CloudSubscriber.php
   @@ -97,14 +98,17 @@ class CloudSubscriber implements EventSubscriberInterface {
   +      if (empty($ids) && empty($cloud_config_type)) {
   +        $url = Url::fromRoute('system.modules_list');
   +        $this->messenger->addWarning(
   +          $this->t('There is no cloud service provider. Please add cloud service provider(s) (AWS, K8s and/or OpenStack)'));
            $response = new RedirectResponse($url->toString());
            $event->setResponse($response);
   

   This message should show up on all pages a user visits. Not just these routes

       $route_names = [
         'view.cloud_config.list',
         'view.cloud_server_template.list',
         'entity.cloud_server_template.collection',
         'entity.cloud_config.add_page',
       ];
   

2. +++ b/src/EventSubscriber/CloudSubscriber.php
   @@ -97,14 +98,17 @@ class CloudSubscriber implements EventSubscriberInterface {
   +          $this->t('There is no cloud service provider. Please add cloud service provider(s) (AWS, K8s and/or OpenStack)'));
   

   Please link this to admin/modules page.

@jigish, Thank you for the updated patch. I have two comments.

+++ b/src/EventSubscriber/CloudSubscriber.php
@@ -92,23 +104,25 @@ class CloudSubscriber implements EventSubscriberInterface {
+        $this->t('There is no cloud service provider. Please add @link (AWS, K8s and/or OpenStack).',

Can we modify the wording as follows:

There are no Cloud Service Provider modules enabled. Please enable AWS Cloud, Kubernetes and/or OpenStack.

where @link text is "AWS Cloud, Kubernetes and/or OpenStack"

+++ b/src/EventSubscriber/CloudSubscriber.php
@@ -92,23 +104,25 @@ class CloudSubscriber implements EventSubscriberInterface {
-      if (empty($ids)) {
-        $url = Url::fromRoute('entity.cloud_config.add_page');
-        $page_link = Link::fromTextAndUrl($this->t('cloud service provider'), $url)->toString();
-        $this->messenger->addMessage(
-          $this->t('There is no cloud service provider. Please create a new @link.', [
-            '@link' => $page_link,
-          ])
-        );

Please put this condition back. It throws up a message asking user to add a Cloud Config entity and should still be there.

@jigishaddweb

Just a quick question --- Is the patch's code

+++ b/src/EventSubscriber/CloudSubscriber.php
@@ -79,7 +79,19 @@ class CloudSubscriber implements EventSubscriberInterface {

+    $ids = $this->entityTypeManager
+      ->getStorage('cloud_config')
+      ->getQuery()
+      ->execute();

equivalent to the code as follows?

  $ids = $this->entityTypeManager->getStorage('cloud_config')
    ->loadMultiple();

@jigishaddweb

Thank you for the update. It looks good to me now.

@baldwinlouie

What do you think?

@jigishaddweb and @yas, The patch looks good now.

@baldwinlouie

Thank you for your review. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

@jigishaddweb

I found that testCloudConfigRedirect() fails. Could you please fix it?

@jigishaddweb

Thank you for fixing the issue. I tested it and looks good to me. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.