Problem/Motivation

We should be compatible with Drupal 9. It seems we just need

core_version_requirement: ^8.7.7 || ^9

instead of old

core: 8.x

And let's add update function that updates this automatically in child themes.

CommentFileSizeAuthor
#10 drupal-9-compatibility-3114029-10.patch2.42 KBberdir
#9 drupal-9-compatibility-3114029-9.patch1.75 KBpivica
#9 interdiff-3114029-5-9.txt1.62 KBpivica
#8 3114029-8.patch1.97 KBrithesh bk
#5 drupal-9-compatibility-3114029-5.patch1.77 KBpivica
#5 interdiff-3114029-3-5.txt1.61 KBpivica
#3 drupal-9-compatibility-3114029-3.patch1.49 KBpivica
#2 drupal-9-compatibility-3114029-2.patch1.99 KBpivica

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica commented
StatusFileSize
new drupal-9-compatibility-3114029-2.patch1.99 KB

Here is a patch that requires other dev patches, so it will fail if you try to apply it to current dev. A new release is coming this week so this should not be a big deal.

pivica’s picture

pivica commented
StatusFileSize
new drupal-9-compatibility-3114029-3.patch1.49 KB

The previous patch got one change for another issue, here is a correct one.

pivica’s picture

pivica commented
Status: Active » Needs review
Issue tags: +next-release
pivica’s picture

pivica commented
StatusFileSize
new interdiff-3114029-3-5.txt1.61 KB
new drupal-9-compatibility-3114029-5.patch1.77 KB

Let's use `^8` instead of `^8.7.7` and forgot to add composer.json dependency for core and we can also add dependency to bs_lib.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work 
+++ b/bs_base.bs_base.install
@@ -65,3 +65,15 @@ function bs_base_bs_update_8003($target_theme_name) {
+    _bs_base_regexp_file($themes_info[$target_theme_name]->subpath . '/' . $target_theme_name . '.info.yml', [
+      'core: 8.x' => 'core_version_requirement: ^8 || ^9',
+    ]);

+++ b/bs_base.info.yml
@@ -2,7 +2,7 @@ name: BS Base
 base theme: false
-core: 8.x
+core_version_requirement: ^8 || ^9

if you replace core then you need to use ^8.7.7 because that is the oldest version that supports it, anything below will give you a fatal error anyway.

Alternatively, add the new line below without removing core: 8.x

rithesh bk’s picture

rithesh bk commented
Assigned: Unassigned » rithesh bk
Issue tags: +VbContribution2020

currently i am working on it ....

rithesh bk’s picture

rithesh bk commented
Assigned: rithesh bk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3114029-8.patch1.97 KB

#5 drupal-9-compatibility-3114029-5.patch is not working ....... Please find the updated patch .......

pivica’s picture

pivica commented
StatusFileSize
new interdiff-3114029-5-9.txt1.62 KB
new drupal-9-compatibility-3114029-9.patch1.75 KB

@Rithesh BK thx, but your patch has one additional update function 8003 from another place and is missing one more change that I've discussed with @Berdir in chat. Also, you are missing interdiff and it's difficult then to easily review your patch, make sure you always upload interdiff when basing your changes on previous patches.

@Rithesh BK if you are interested in helping with this theme issues ping me in reply, there are plenty of other stuff that needs help/work.

> if you replace core then you need to use ^8.7.7
> Alternatively, add the new line below without removing core: 8.x

Let's then go just with ^8.7.7 because it's one line change. Also removed bs_lib composer dependency as we discussed.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new drupal-9-compatibility-3114029-10.patch2.42 KB

@ivica: A bit confused by your workflows, managing these layers of pages is quite tricky, why not just commit things that are ready? This makes it really hard for others to contribute.

That said, turns out that this actually wasn't ready, there is a path.alias_manager usage and that requires 8.8 to fix, so updated the version requirement for bs_base. Didn't touch the update function and bs_bootstrap, since the subthemes technically don't require 8.8 themself and we've already deployed this in our projects, so we'd need to support updating from both old values.

pivica’s picture

pivica commented

> why not just commit things that are ready?

@Berdir thanks for kicking me in the butt and reminding me that i should really push a new version :) Just added a patch for old #3073559-2: Add a helper class to hide fieldset legend. Starting now with committing all prepared patches.

  • pivica committed 322c592 on 8.x-1.x authored by Berdir 
    Issue #3114029 by pivica, Berdir: Drupal 9 compatibility
pivica’s picture

pivica commented
Status: Needs review » Fixed
Issue tags: -next-release, -VbContribution2020

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.