Problem/Motivation

The Commerce File field formatter settings display a summary, but you cannot edit the settings.

Proposed resolution

Fix the formatter so the settings can be changed.

CommentFileSizeAuthor
#2 3113870-formatter-settings-2.patch2.24 KBdaniel korte

Comments

Daniel Korte created an issue. See original summary.

daniel korte’s picture

daniel korte
he/him/his
Primary language English
Location Brooklyn, NY
commented
Assigned: daniel korte » Unassigned
Status: Active » Needs review
StatusFileSize
new 3113870-formatter-settings-2.patch2.24 KB

The parent::settingsForm() call fixes this specific issue, but I figured I’d simplify the whole file by using the parent’s code for the defaultSettings() and settingsSummary() too.

nathaniel’s picture

nathaniel commented
Status: Needs review » Fixed

I did not experience the issue with the settings not opening, but this is nice work, thanks for the patch!

daniel korte’s picture

daniel korte
he/him/his
Primary language English
Location Brooklyn, NY
commented

I didn't mention I was using Claro as my admin theme. That may be part of why you aren't seeing the issue, but either way thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.