Problem/Motivation

Add object that uses the FactoryInterface should have dependencies inject via ::create and not ::__construct(). This allows parent classes to change their constructor without breaking any code.
See https://events.drupal.org/seattle2019/sessions/drupal-9-coming-getting-y...
See https://www.drupal.org/core/d8-bc-policy

Example: \Drupal\config_sync\Controller\ConfigSyncController::create
See https://www.youtube.com/watch?time_continue=1554&v=hN9KjaBvAUk
See https://www.previousnext.com.au/blog/safely-extending-drupal-8-plugin-cl...

Proposed resolution

Fix subclassing and stop overriding constructors.

CommentFileSizeAuthor
#3 interdiff-3113521-2-3.txt1.2 KBmegachriz
#3 feeds-Fix-subclassing-and-stop-overriding-constructors-in-Drupal-feeds-FeedForm-3113521-3.patch2.18 KBmegachriz
#2 feeds-Fix_subclassing_and_stop_overriding_constructors_in_Drupal_feeds_FeedForm-3113521-2-D8.patch1.99 KBthalles

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new feeds-Fix_subclassing_and_stop_overriding_constructors_in_Drupal_feeds_FeedForm-3113521-2-D8.patch1.99 KB

Follow a patch

megachriz’s picture

megachriz
Primary language Dutch
commented
StatusFileSize
new feeds-Fix-subclassing-and-stop-overriding-constructors-in-Drupal-feeds-FeedForm-3113521-3.patch2.18 KB
new interdiff-3113521-2-3.txt1.2 KB

Good idea, but let's make the dependency on PluginFormFactory slightly more explicit.

  • MegaChriz committed 80a0344 on 8.x-3.x 
    Issue #3113521 by MegaChriz, thalles: Fixed subclassing and stop...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Committed #3. Thanks for contributing, Thalles.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.