Drupal 9 is coming, lets make this module ready!

CommentFileSizeAuthor
#12 3113329-12-d9.patch9.78 KBbojanz
#11 3113329-11-d9.patch5.38 KBbojanz
#9 interdiff_5-9.txt8.16 KBneelam_wadhwani
#9 3113329-9.patch4.94 KBneelam_wadhwani
#5 interdiff_2-5.txt4.09 KBswatichouhan012
#5 3113329-5.patch4.92 KBswatichouhan012
#2 3113329.patch332 byteseiriksm

Comments

eiriksm created an issue. See original summary.

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Active » Needs review
StatusFileSize
new 3113329.patch332 bytes
bojanz’s picture

bojanz commented
Status: Needs review » Needs work 
Unable to install modules: module 'physical_test' is incompatible with this version of Drupal core.

We need to do the same to physical_test. While we're at it, we should remove the code line and require Drupal ^8.7.7 in the composer.json

Error: Call to undefined method Drupal\Tests\physical\Unit\WeightTest::setExpectedException()

Tests are still using deprecated phpunit methods.

swatichouhan012’s picture

swatichouhan012 commented
Assigned: Unassigned » swatichouhan012
Issue tags: +VbContribution2020
swatichouhan012’s picture

swatichouhan012 commented
Assigned: swatichouhan012 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3113329-5.patch4.92 KB
new interdiff_2-5.txt4.09 KB

I have removed deprecated method setExpectedException(), also removed deprecated drupal_set_message, kindly review patch.

Status: Needs review » Needs work

The last submitted patch, 5: 3113329-5.patch, failed testing. View results

bojanz’s picture

bojanz commented

Patches are usually not reviewed until they start passing tests :)
In this case the tests are failing cause you changed core_version_requirement, and it's now invalid.

 core: 8.x
+core_version_requirement: ^8.7 || ^9

The core line needs to be removed. The core_version_requirement line needs to use ^8.7.7 || ^9

neelam_wadhwani’s picture

neelam_wadhwani commented
Assigned: Unassigned » neelam_wadhwani
neelam_wadhwani’s picture

neelam_wadhwani commented
Assigned: neelam_wadhwani » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3113329-9.patch4.94 KB
new interdiff_5-9.txt8.16 KB

I have done with additional changes and done testing.
Module is working fine.

Status: Needs review » Needs work

The last submitted patch, 9: 3113329-9.patch, failed testing. View results

bojanz’s picture

bojanz commented
Status: Needs work » Needs review
Issue tags: -VbContribution2020
StatusFileSize
new 3113329-11-d9.patch5.38 KB

Started from scratch. Let's try this.

bojanz’s picture

bojanz commented
StatusFileSize
new 3113329-12-d9.patch9.78 KB

Getting closer. Let's add a custom comparator like we did for prices.

bojanz’s picture

bojanz commented
Title: Drupal 9 readiness » Allow the module to be used on D9

Better title.

  • bojanz committed f28dd74 on 8.x-1.x 
    Issue #3113329 by bojanz, neelam_wadhwani, swatichouhan012, eiriksm:...
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Committed. Thanks, everyone.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.