drupal-check docroot/modules/contrib/varbase_seo


 2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------------------------- 
  Line   varbase_seo.install                                                  
 ------ --------------------------------------------------------------------- 
  40     Call to deprecated function file_scan_directory():                   
         in drupal:8.8.0 and is removed from drupal:9.0.0.                    
         Use \Drupal\Core\File\FileSystemInterface::scanDirectory() instead.  
  55     Call to deprecated function file_scan_directory():                   
         in drupal:8.8.0 and is removed from drupal:9.0.0.                    
         Use \Drupal\Core\File\FileSystemInterface::scanDirectory() instead.  
  66     Call to deprecated function file_scan_directory():                   
         in drupal:8.8.0 and is removed from drupal:9.0.0.                    
         Use \Drupal\Core\File\FileSystemInterface::scanDirectory() instead.  
 ------ --------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 3 errors                                                                                                                                                                                                                   


Upgrade status


CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Varbase SEO 8.x-6.x-dev
Scanned on Thu, 02/13/2020 - 16:00.

1 warning found.

#3113189: Drupal 9 Readiness for [Varbase SEO] with Drupal coding standard and
practice

modules/contrib/varbase_seo/varbase_seo.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                        MESSAGE                         │
├──────────┼──────┼────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to │
│ manually │      │ varbase_seo.info.yml to designate that the module is   │
│          │      │ compatible with Drupal 9. See                          │
│          │      │ https://www.drupal.org/node/3070687.                   │
│          │      │                                                        │
└──────────┴──────┴────────────────────────────────────────────────────────┘




Drupal coding standard and Drupal Practice check should pass

PHPCS, PHPCBF for both --standard=Drupal and --standard=DrupalPractice

Check Varbase SEO Drupal coding standard

phpcbf --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_seo/

phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_seo/

Check Varbase SEO Drupal Practice

phpcbf --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_seo/

phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_seo/


Comments

RajabNatshah created an issue. See original summary.

rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

  • RajabNatshah committed 8d52437 on 8.x-6.x
    Issue #3113189: Drupal 9 Readiness for [Varbase SEO] with Drupal coding...
rajab natshah’s picture

rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
Status: Active » Needs review
Issue tags: +varbase-8.8.4, +varbase-8.9.0, +varbase-9.0.0
rajab@vardot-dev:/var/www/html/products/varbase_seo$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md /var/www/html/products/varbase_seo/

rajab@vardot-dev:/var/www/html/products/varbase_seo$ phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md /var/www/html/products/varbase_seo/


rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue tags: -varbase-9.0.0 +varbase-9.1.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

rajab natshah’s picture

Title: Drupal 9 Readiness for [Varbase SEO] with Drupal coding standard and practice » Drupal 9 compatibility for [Varbase SEO] with Drupal coding standard and practice
rajab natshah’s picture

Issue tags: +varbase-9.0.0-alpha1