drupal-check docroot/modules/contrib/varbase_landing

2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------------------------- 
  Line   varbase_landing.install                                              
 ------ --------------------------------------------------------------------- 
  40     Call to deprecated function file_scan_directory():                   
         in drupal:8.8.0 and is removed from drupal:9.0.0.                    
         Use \Drupal\Core\File\FileSystemInterface::scanDirectory() instead.  
  55     Call to deprecated function file_scan_directory():                   
         in drupal:8.8.0 and is removed from drupal:9.0.0.                    
         Use \Drupal\Core\File\FileSystemInterface::scanDirectory() instead.  
 ------ --------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 2 errors


Upgrade status


CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Varbase Landing 8.x-7.x-dev
Scanned on Thu, 02/13/2020 - 15:59.

1 warning found.

#3113176: Drupal 9 Readiness for [Varbase Landing] with Drupal coding standard
and practice

modules/contrib/varbase_landing/varbase_landing.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                         MESSAGE                          │
├──────────┼──────┼──────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to   │
│ manually │      │ varbase_landing.info.yml to designate that the module is │
│          │      │ compatible with Drupal 9. See                            │
│          │      │ https://www.drupal.org/node/3070687.                     │
│          │      │                                                          │
└──────────┴──────┴──────────────────────────────────────────────────────────┘




Drupal coding standard and Drupal Practice check should pass

PHPCS, PHPCBF for both --standard=Drupal and --standard=DrupalPractice

Check Varbase Landing Drupal coding standard

phpcbf --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_landing/

phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_landing/

Check Varbase Landing Drupal Practice

phpcbf --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_landing/

phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_landing/


Comments

RajabNatshah created an issue. See original summary.

rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes
pavnish’s picture

Assigned: rajab natshah » pavnish
pavnish’s picture

Assigned: pavnish » Unassigned
Status: Active » Needs review
StatusFileSize
new1.83 KB

Hi @RajabNatshah
Could you please review this patch.I think it would be fit for this.

  • RajabNatshah committed 38ba404 on 8.x-7.x authored by pavnish
    Issue #3113176 by pavnish: Drupal 9 Readiness for [Varbase Landing] with...
rajab natshah’s picture

Thank you, Pavnish for helping

rajab@vardot-dev:/var/www/html/products/varbase_landing$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md /var/www/html/products/varbase_landing/

rajab@vardot-dev:/var/www/html/products/varbase_landing$ phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md /var/www/html/products/varbase_landing/


rajab natshah’s picture

Status: Needs review » Fixed
Issue tags: +varbase-8.8.4, +varbase-8.9.0, +varbase-9.1.0
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

rajab natshah’s picture

Title: Drupal 9 Readiness for [Varbase Landing] with Drupal coding standard and practice » Drupal 9 compatibility for [Varbase Landing] with Drupal coding standard and practice