Problem/Motivation

Add object that uses the FactoryInterface should have dependencies inject via ::create and not ::__construct(). This allows parent classes to change their constructor without breaking any code.
See https://events.drupal.org/seattle2019/sessions/drupal-9-coming-getting-y...
See https://www.drupal.org/core/d8-bc-policy

Example: \Drupal\config_sync\Controller\ConfigSyncController::create
See https://www.youtube.com/watch?time_continue=1554&v=hN9KjaBvAUk
See https://www.previousnext.com.au/blog/safely-extending-drupal-8-plugin-cl...

Proposed resolution

Fix subclassing and stop overriding constructors.

CommentFileSizeAuthor
#5 3113089-sub-classing-5.patch4.02 KBgausarts
#2 blazy-Fix_subclassing_and_stop_overriding_constructors_in_blazy_Plugin_Field_FieldFormatter_BlazyMediaFormatterBase-3113089-2-D8.patch3.01 KBthalles

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Title: Fix subclassing and stop overriding constructors in blazy\Plugin\Field\FieldFormatter » Fix subclassing and stop overriding constructors in blazy\Plugin\Field\FieldFormatter\BlazyMediaFormatterBase
StatusFileSize
new blazy-Fix_subclassing_and_stop_overriding_constructors_in_blazy_Plugin_Field_FieldFormatter_BlazyMediaFormatterBase-3113089-2-D8.patch3.01 KB

Follow a patch

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
gausarts’s picture

gausarts commented
Status: Needs review » Postponed (maintainer needs more info)

Similar to my other comment here, we should consider setters. Thanks!

gausarts’s picture

gausarts commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new 3113089-sub-classing-5.patch4.02 KB

We'll change a bit to make easy for copy paste through all blazy formatters.
Let's see if any issue.

  • gausarts committed 3b30421 on 8.x-2.x authored by thalles 
    Issue #3113089 by thalles, gausarts: Fix subclassing and stop overriding...
gausarts’s picture

gausarts commented
Status: Needs review » Fixed

We got a release to catch up. Let's get the ball rolling. Improvements are very much welcome and may follow as always.

Committed for wider feedback. Feel free to re-open if any (side) issue. Thank you for contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.