Hey there, so I noticed that the rate pages are being indexed by Google, we need to have this disabled by default or have an option to maybe enable it in case of need

CommentFileSizeAuthor
#9 rate-nofollow-3113003-9.patch20.02 KBlamp5
#2 rate-nofollow-3113003-2.patch17.38 KBlamp5
Screenshot 2020-02-12 at 11.59.35.png74.84 KBdoxigo

Comments

doxigo created an issue. See original summary.

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented
Status: Active » Needs review
StatusFileSize
new rate-nofollow-3113003-2.patch17.38 KB

I refactored widgets templates, added rel="nofollow" to the links, also unused destination parameter was removed from route parameters.

doxigo’s picture

doxigo commented

Thanks for an amazing fast patch, but unfortunately it doesn't respect the twig {{ content.rate_vote_widget }} and the widget is completely missing now

Possible related error:
User error: "rel" is an invalid render array key in Drupal\Core\Render\Element::children() (line 97 of core/lib/Drupal/Core/Render/Element.php).

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented

Did you clear cache after applied patch?

doxigo’s picture

doxigo commented

Yes, I just noticed it, probably my bad, but it broke the HTML structure, here's the output I get now:
<a href="<a href=" rate="" node="" 80481="" updown="" 1="" thumbs_up"="" class="rate-thumbs-up-btn-up use-ajax" rel="nofollow">Opp</a>, the href is repeated twice but `rel` is there

doxigo’s picture

doxigo commented
Status: Needs review » Reviewed & tested by the community

Okay ignore my last comment, seems like it was overriden by a template file in the theme itself, works great.. thanks

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: rate-nofollow-3113003-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

krzysztof domański’s picture

krzysztof domański
Location Poland
commented

There is a problem when rate does not use AJAX. We get into an infinite redirect loop ERR_TOO_MANY_REDIRECTS.

Steps to reproduce issue

Uncheck "Use AJAX" checkbox at /admin/config/search/votingapi/rate.
Try to vote and unvote for any entity.

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented
Status: Needs work » Needs review
StatusFileSize
new rate-nofollow-3113003-9.patch20.02 KB
ivnish’s picture

ivnish
he/him
commented
Version: 8.x-1.x-dev » 3.1.x-dev
Status: Needs review » Needs work

Needs reroll to MR

ivnish’s picture

ivnish
he/him
commented
Status: Needs work » Postponed (maintainer needs more info)

I this still relevant?

doxigo’s picture

doxigo commented

I assume not.

ivnish’s picture

ivnish
he/him
commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.