SimplePie library $file paths needs to be updated in feeds_simplepie_exists() to reflect the current SimplePie files structure.

CommentFileSizeAuthor
#2 3112921-2.patch841 bytestormi

Issue fork feeds-3112921

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tormi created an issue. See original summary.

tormi’s picture

tormi
Primary language Estonian
Location Tallinn
commented
Status: Active » Needs review
StatusFileSize
new 3112921-2.patch841 bytes

Patch added.

tormi’s picture

tormi
Primary language Estonian
Location Tallinn
commented
Issue summary: View changes

Added link to GitHub.

Status: Needs review » Needs work

The last submitted patch, 2: 3112921-2.patch, failed testing. View results

tormi’s picture

tormi
Primary language Estonian
Location Tallinn
commented

feeds.install & README.txt needs also updating.

joelpittet made their first commit to this issue’s fork.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review

joelpittet opened merge request !39

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

I merged your patch into the PR, looking at bumping this to 1.5.6 for PHP 8 support.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue tags: +PHP 8.1
Parent issue: » #3254188: PHP 8.0/8.1 compatibility

  • joelpittet committed b7ac60b on 7.x-2.x 
    Issue #3112921: Update SimplePie $file paths in feeds_simplepie_exists()
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

Thank you @tormi for starting this issue. My apologies for the MR not adding you to the code commit credit as I intended.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.