Hey,

I've notices, that die SubscriptionBlockForm print the message form element in any case.
The message field on the BlockForm is optional, so the BlockForm should handle this to not print empty HTML containers.

It is a tiny change, but an improvement for frontend related stuff.
In my case, there is a empty bordered form-element what I want to avoid.

I will attach a patch for that.

What do you think?

CommentFileSizeAuthor
#4 simplenews-3112819-4.patch593 bytessunlix
#2 simplenews-3112819-2.patch706 bytessunlix

Comments

sunlix created an issue. See original summary.

sunlix’s picture

sunlix
Primary language English
Location Wesel
commented
StatusFileSize
new simplenews-3112819-2.patch706 bytes
adamps’s picture

adamps commented
Version: 8.x-1.x-dev » 8.x-2.x-dev

Seems reasonable. Patches should be against the 2.x version now please.

sunlix’s picture

sunlix
Primary language English
Location Wesel
commented
StatusFileSize
new simplenews-3112819-4.patch593 bytes

Okay. Here is the patch against 8.x-2.x branch.

adamps’s picture

adamps commented
Status: Active » Reviewed & tested by the community
Issue tags: +Plan to commit

Looks good to me, will commit.

  • AdamPS committed edd2766 on 8.x-2.x authored by sunlix 
    Issue #3112819 by sunlix: SubscriptionsBlockForm should print "message"...
adamps’s picture

adamps commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Plan to commit

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.