Problem/Motivation

XML markup is supported by default on the php dom extension.
Parsing xml can be really handy on may migration situations, e.g. when the source system is storing data using xml.

Proposed resolution

Use default dom php extension support for xml parsing into a \DOMDocument object, adding an extra parameter inside the dom plugin, similarly than at #3096393: Support html5 parsing on dom plugin.

Remaining tasks

Provide a patch
Code review

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#3 3112571-3.patch2.79 KBmatroskeen
#2 3112571-2-xml-dom-import.patch1.29 KBmarvil07

Comments

marvil07 created an issue. See original summary.

marvil07’s picture

marvil07 commented
Assigned: marvil07 » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3112571-2-xml-dom-import.patch1.29 KB

This patch is on top of #3096393-10: Support html5 parsing on dom plugin, so it will not apply here directly.
I can make a stand-alone patch, but it is more sensible to depend on that change, since it is generalizing the way to do the import for dom plugin.

matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
StatusFileSize
new 3112571-3.patch2.79 KB

[#13458857] is landed, so here is a re-roll of #2. There is no interdiff, because it just adds a simple test to check that "XML" mode is supported.

  • Matroskeen committed 6614906 on 8.x-5.x 
    Issue #3112571 by marvil07, Matroskeen: Support xml parsing on dom...

  • Matroskeen committed aa94a69 on 6.0.x 
    Issue #3112571 by marvil07, Matroskeen: Support xml parsing on dom...
matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Status: Needs review » Fixed

Committed to 8.x-5.x and cherry-picked to 6.0.x.
Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.