Closed (fixed)
Project:
Layout Builder Modal
Version:
8.x-1.x-dev
Component:
Documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Feb 2020 at 17:56 UTC
Updated:
25 Jan 2022 at 13:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
WebbehPatch applied to bring README.MD into best practices.
Comment #3
WebbehComment #4
Anonymous (not verified) commentedComment #5
ricksta commentedTested and checks out fine.
Comment #6
ricksta commentedI actually found a few typos, so here's a new patch and interdiff.
Comment #7
ricksta commentedAnd the patch.
Comment #8
volkswagenchickI am asking that this issue be reserved for a novice during DrupalCon. Thanks
Adding
NorthAmerica2021tag for visbility.DrupalCon NA is April 12-16 with a focus on EOOTB on Wednesday, April 14. This is a layout builder adjacent extension and is used in addition to core.
Thanks
Comment #9
marcusvsouza commentedThe patch in comment #7 does not apply, so i did a re-roll of the patch and add some information to match with the standards
Comment #10
volkswagenchickThere is an empty space at the end of line 32
There needs to be hard line breaks at 80 characters
Two lines before headings.
I suggest working off the patch in comment 2. Thanks. Moving to needs work
Comment #11
ankithashettyAs suggested in #10, updated the patch in #2 to fix minor typo issues. Attached an interdiff file as well.
And looks like the patch & interdiff submitted in #6 and #7 have exchanged their file extension! So they are not valid files.
Thank you!
Comment #12
marcusvsouza commentedThe patch in comment #11 correctly apply the standards and fix the typo off comment #2.
Comment #13
johnwebdev commentedHello!
Thanks for the patch and work so far!
Looks like there is some bad encoding in here: -Let’s, let’s that needs to be resolved.
Comment #14
manthan.chauhan commentedHello @johnwebdev,
Corrected special characters, kindly review patch.
Thanks
Comment #15
hmendes commentedThe patch look great now. Changing this to RTBC.
Comment #16
johnwebdev commentedStill some occurrences of Let’s for me.
Comment #17
hmendes commentedHello, The occurrences of Let’s missing are in the parts the are being removed... is that a problem?
The current code is writing lets with the ’ character instead of ' That's why the problem is happening.
Comment #18
volkswagenchickLine 55 - let's not use a node alias.
Let's use
https://www.drupal.org/node/1897420/instead. That was it is drupal version agnostic.Comment #19
hmendes commentedAdding the suggestion from #18.
Comment #20
dandeleon03 commentedHi @hmendes,
Checked and confirmed that node alias is no longer used.
Kindly see screenshot.
Thanks.
Comment #21
dandeleon03 commentedComment #22
johnzzonThere are still 2 occurrences of "Let’s". Please write the text in UTF-8 encoding.
EDIT: I just read that they're in the removed lines as you said. Can anyone confirm that it applies cleanly? If so, it shouldn't be an issue.
Comment #23
WebbehConfirming patch #19 resolves this - returning to RTBC.
Comment #25
johnzzonPatch merged! Thanks for everyone's participation, it's greatly appreciated!
Comment #26
johnzzon