oEmbed feature in drupal core doesn't process arguments in Vimeo links such as ?controls=0, which we need to hide the controls option of the video. That's because in oEmbed, the argument indicators and separators ? and & should be replaced to /& (for example https://vimeo.com/api/oembed.json?url=https://vimeo.com/111111111/&contr...).

Comments

mhawwari created an issue. See original summary.

mhawwari’s picture

Assigned: mhawwari » Unassigned
Status: Active » Needs review
StatusFileSize
new716 bytes

Core provides a hook to alter the URLs so I used this hook to make the Vimeo URLs compatible with oEmbed's format

    // Let other modules alter the resource URL, because some oEmbed providers
    // provide extra parameters in the query string. For example, Instagram also
    // supports the 'omitscript' parameter.
    $this->moduleHandler->alter('oembed_resource_url', $parsed_url, $provider);
rajab natshah’s picture

StatusFileSize
new670 bytes
rajab natshah’s picture

StatusFileSize
new663 bytes
rajab natshah’s picture

Title: oEmbed does not recognize Vimeo arguments » Fix oEmbed issue of not recognizeing Vimeo arguments
rajab natshah’s picture

  • RajabNatshah committed 8fabe7b on 8.x-7.x authored by mhawwari
    Issue #3112241 by mhawwari: Fix oEmbed issue of not recognizeing Vimeo...
rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
Issue tags: +varbase-8.8.3, +varbase-8.7.5
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Title: Fix oEmbed issue of not recognizeing Vimeo arguments » Fix oEmbed issue of not recognizing Vimeo arguments

  • RajabNatshah committed 16671a5 on 8.x-7.x
    Issue #3112241: Fix oEmbed issue of not recognizing Vimeo arguments
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.