CommentFileSizeAuthor
#5 interdiff_2-5.txt1.2 KBravi.shankar
#5 3111865-5.patch6.26 KBravi.shankar
#2 3111865-2.patch6.16 KBhardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3111865-2.patch6.16 KB

Kindly review a patch.

hardik_patel_12’s picture

hardik_patel_12 commented
Assigned: hardik_patel_12 » Unassigned
Status: Needs work » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work
Parent issue: » #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch 
+++ b/core/modules/media_library/src/Form/FileUploadForm.php
@@ -77,15 +77,11 @@ class FileUploadForm extends AddFormBase {
+  public function __construct(EntityTypeManagerInterface $entity_type_manager, MediaLibraryUiBuilder $library_ui_builder, ElementInfoManagerInterface $element_info, RendererInterface $renderer, FileSystemInterface $file_system, OpenerResolverInterface $opener_resolver = NULL, FileUsageInterface $file_usage) {

$opener_resolver no longer needs to default to NULL here.

ravi.shankar’s picture

ravi.shankar commented
Status: Needs work » Needs review
StatusFileSize
new 3111865-5.patch6.26 KB
new interdiff_2-5.txt1.2 KB

Here I have made changes as suggested in comment #4.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Looks good, I double checked after applying the patch and found no more @deprecated references or relevant @todos in media_library.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed bbf1063 and pushed to 9.0.x. Thanks!

  • alexpott committed bbf1063 on 9.0.x 
    Issue #3111865 by ravi.shankar, Hardik_Patel_12, longwave: Remove all @...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.