It'd make building test coverage easier for the Date Popup module on new patches if the existing test coverage was split out from the main module's tests. Also, some test files should be under their respective submodule rather than lumped into the main test directory.

CommentFileSizeAuthor
#20 date-n3111299-20.patch26.63 KBdamienmckenna
#19 date-n3111299-19.patch25.58 KBdamienmckenna
#17 date-n3111299-17.patch19.06 KBdamienmckenna
#15 date-n3111299-15.patch18.89 KBdamienmckenna
#13 date-n3111299-13.patch18.67 KBdamienmckenna
#11 date-n3111299-11.patch17.53 KBdamienmckenna
#9 date-n3111299-9.patch15.49 KBdamienmckenna
#8 date-n3111299-8.patch15.49 KBdamienmckenna
#6 date-n3111299-6.patch14.07 KBdamienmckenna
#6 date-n3111299-6.interdiff.txt17.19 KBdamienmckenna
#4 date-n3111299-4.patch6.73 KBdamienmckenna
#4 date-n3111299-4.interdiff.txt853 bytesdamienmckenna
#2 date-n3111299-2.patch6.42 KBdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new date-n3111299-2.patch6.42 KB

This is a step in the right direction, though some custom support is still needed in dateForm().

Status: Needs review » Needs work

The last submitted patch, 2: date-n3111299-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new date-n3111299-4.interdiff.txt853 bytes
new date-n3111299-4.patch6.73 KB

Forgot to set a default value on a new method.

Status: Needs review » Needs work

The last submitted patch, 4: date-n3111299-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new date-n3111299-6.interdiff.txt17.19 KB
new date-n3111299-6.patch14.07 KB

Further work splitting off the date_popup test coverage.

Status: Needs review » Needs work

The last submitted patch, 6: date-n3111299-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Split out test coverage for Date Popup module » Test refactoring, split out Date Popup tests, move tests to appropriate submodule
Issue summary: View changes
StatusFileSize
new date-n3111299-8.patch15.49 KB

Expanding the scope of this because it needed a general tidyup.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new date-n3111299-9.patch15.49 KB

I think this should be closer.

Status: Needs review » Needs work

The last submitted patch, 9: date-n3111299-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new date-n3111299-11.patch17.53 KB

This covers some more refactoring.

Status: Needs review » Needs work

The last submitted patch, 11: date-n3111299-11.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new date-n3111299-13.patch18.67 KB

Making more progress.

Status: Needs review » Needs work

The last submitted patch, 13: date-n3111299-13.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new date-n3111299-15.patch18.89 KB

Should fix the timezone part.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new date-n3111299-17.patch19.06 KB

The DatePopupValidationTestCase should work now, I forgot to override setUp() to add the date_popup module. Doh.

The last submitted patch, 15: date-n3111299-15.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new date-n3111299-19.patch25.58 KB

Some more shuffling. Because.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new date-n3111299-20.patch26.63 KB

There was more shuffling to be done.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed 5355165 on 7.x-2.x 
    Issue #3111299 by DamienMcKenna: Test refactoring, split out Date Popup...
steinmb’s picture

steinmb commented

Good work :) !

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: damienmckenna » Unassigned