Coder 3.7 dropped the Drupal.WhiteSpace.OperatorSpacing in #3082623: Is it still necessary to override OperatorSpacingSniff? however it is still used in phpcs.xml.

CommentFileSizeAuthor
#3 3111130-3--drupal_whitespace_operator_sniff_removed.patch583 bytesdrunken monkey
#2 search_api-phpcs_update-3111130-2.patch431 bytesbwaindwain

Comments

bwaindwain created an issue. See original summary.

bwaindwain’s picture

bwaindwain
Location Calgary
commented
Status: Active » Needs review
StatusFileSize
new search_api-phpcs_update-3111130-2.patch431 bytes
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
StatusFileSize
new 3111130-3--drupal_whitespace_operator_sniff_removed.patch583 bytes

Thanks a lot for reporting this issue!
However, shouldn’t we follow Core here (#3099796: Coder 3.7: Referenced sniff "Drupal.WhiteSpace.OperatorSpacing" does not exist) and replace the old line with a reference to the base sniff, instead of just removing it?
Patch attached, feedback welcome!

bwaindwain’s picture

bwaindwain
Location Calgary
commented

looks good to me

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Great, thanks for reporting back!
Committed.
Thanks again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.