Problem/Motivation

Maybe this is because we are using a patch from #3020448: Invalid translations of the ContentModerationState entity created before #2946402 exist in some installations of content_moderation and have some inconsistent data, but it I imagine it might also be possible to reproduce when the langcode of the default translation changes.

Proposed resolution

As a quickfix, don't delete that that "translation". Not sure what else we could do.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 3109772-test-only.patch1.86 KBsam152
#2 content-moderation-translation-delete-3109772-2.patch1.12 KBberdir

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new content-moderation-translation-delete-3109772-2.patch1.12 KB

This is also basically the same fix as #3003238: EntityStorageException: Default revision can not be deleted in content_moderation_entity_revision_delete() just for translations instead of revisions.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: Exception when deleting a translation that is the default translation on the content moderation stat entity » Exception when deleting a translation that is the default translation on the content moderation state entity
sam152’s picture

sam152 commented

I didn't think it was possible to remove the default translation of an entity, seems to be the first link in removeTranslation:

public function removeTranslation($langcode) {
    if (isset($this->translations[$langcode]) && $langcode != LanguageInterface::LANGCODE_DEFAULT && $langcode != $this->defaultLangcode) {
...

I also think that when the default language of the host entity is changed, the CMS entity default language changes as well, so I'm not totally sure how to reproduce this in a test.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I'll see if I can find a way to reproduce it, could be related to the other issue that we're using as I said.

sam152’s picture

sam152 commented
StatusFileSize
new 3109772-test-only.patch1.86 KB

Fair enough. Here is the test-case that led me to #4 if that's helpful.

Status: Needs review » Needs work

The last submitted patch, 6: 3109772-test-only.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

sam152’s picture

sam152 commented
Issue tags: +content moderation multilingual bug

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.