Fix following error of VolumeAttachDetachTest Testcase

Drupal\Tests\aws_cloud\Functional\Ec2\VolumeAttachDetachTest::testVolumeAttachDetach
TypeError: Argument 1 passed to Drupal\Tests\aws_cloud\Functional\AwsCloudTestCase::updateAttachDetachVolumeMockData() must be of the type array, string given, called in /var/www/html/web/cloud-8/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/VolumeAttachDetachTest.php on line 80
Drupal\Tests\aws_cloud\Functional\Ec2\VolumeAttachDetachTest::testVolumeBulkDetach
TypeError: Argument 1 passed to Drupal\Tests\aws_cloud\Functional\AwsCloudTestCase::updateAttachDetachVolumeMockData() must be of the type array, string given, called in /var/www/html/web/cloud-8/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/VolumeAttachDetachTest.php on line 156
CommentFileSizeAuthor
#6 3109540-6.patch1.07 KBjigish.addweb
#2 3109540-2.patch1.02 KBjigish.addweb

Comments

jigish.addweb created an issue. See original summary.

jigish.addweb’s picture

jigish.addweb commented
Status: Active » Needs review
StatusFileSize
new 3109540-2.patch1.02 KB
jigish.addweb’s picture

jigish.addweb commented
Issue summary: View changes
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@jigishaddweb

Thank you for the fix. Api data should be The API data.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3109540-6.patch1.07 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review

@yas

Thank you for reviewing the patch.

I have changed the parameter comment as per your previous comment.

Please review new patch file.

Thanks

xiaohua guan’s picture

xiaohua guan commented

@jigish.addweb

Thanks for your patch. It looks good to me.

baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Reviewed & tested by the community

@all, Thank you to @xiaohua-guan for reviewing this patch. I'm marking it RTBC.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@guan @baldwinlouie

Thank you for your review. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

  • yas committed 2e71be8 on 8.x-1.x authored by jigish.addweb 
    Issue #3109540 by jigish.addweb, yas, Xiaohua Guan, baldwinlouie: Fix...

  • yas committed fd6f122 on 8.x-2.x authored by jigish.addweb 
    Issue #3109540 by jigish.addweb, yas, Xiaohua Guan, baldwinlouie: Fix...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3095569: Composer could not parse version constraint / could not load package (2)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.