Problem/Motivation
As part of making this module ready for Drupal 9, we should add a missing core_version_requirement key to the module info file and composer.json file.

CommentFileSizeAuthor
#12 3109436-d9-readiness-12.patch857 bytesblakehall
#6 3109436-5.patch720 bytesankush_03
#4 3109436-4.patch723 bytesankush_03
#3 3109436-3.patch691 bytesankush_03

Comments

ankushgautam76@gmail.com created an issue. See original summary.

ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
Assigned: Unassigned » ankush_03
ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
Assigned: ankush_03 » Unassigned
Status: Active » Needs review
StatusFileSize
new 3109436-3.patch691 bytes

Adding patch !

ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
StatusFileSize
new 3109436-4.patch723 bytes
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Needs review » Needs work

Shouldn't we be using a stable version of Token, as there's one available?

ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
StatusFileSize
new 3109436-5.patch720 bytes

Update patch with stable token version.

ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
Status: Needs work » Needs review
lisa.rae’s picture

lisa.rae commented
Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community

Patch addresses versioning issues in composer.json and recurly.info.yml.

Please merge ASAP so the module can be installed on Drupal 9 without using version aliases to "fool" composer.

Thanks!

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

blakehall’s picture

blakehall commented
StatusFileSize
new 3109436-d9-readiness-12.patch857 bytes

I think this issue should be reopened, since recurlyjs and recurly_hosted don't have Drupal 9 compatibility in their info files.

I've attached a patch to add this.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

#12: Please create a new issue, referencing this one. This one is closed/fixed. Also, I can't give you credit if you do it here. Thanks!