Comments

jigish.addweb created an issue. See original summary.

jigish.addweb’s picture

Status: Active » Needs review
StatusFileSize
new54.41 KB
yas’s picture

Status: Needs review » Needs work

@jigishaddweb

Thank you for adding the feature. Could you please change the terminology Api to API for display name?

jigish.addweb’s picture

StatusFileSize
new54.22 KB
jigish.addweb’s picture

Status: Needs work » Needs review

@yas

Thank you for reviewing the patch. I have changed the terminology Api to API.

Please review new patch file.

Thanks

yas’s picture

StatusFileSize
new1.38 MB

@jigishaddweb

Thank you for the update. Let's take care of singular vs plural.

screenshot-20200203a.png

yas’s picture

Status: Needs review » Needs work
jigish.addweb’s picture

StatusFileSize
new56.14 KB
jigish.addweb’s picture

Status: Needs work » Needs review

@yas

Thank you for reviewing the patch. I have made changes as per your last comment.

Please review new patch.

Thanks

yas’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new1.47 MB
new1.17 MB
new1.54 MB
new1.22 MB
new1.55 MB
new1.26 MB
new1.27 MB
new1.57 MB
new1.15 MB
new1.54 MB

@xiaohua-guan

Thank you for the update. I tested it and looks good to me now. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

  • yas committed a66eb51 on 8.x-1.x authored by jigish.addweb
    Issue #3109126 by jigish.addweb, yas: Manage K8s API Services
    

  • yas committed cdce89c on 8.x-2.x authored by jigish.addweb
    Issue #3109126 by jigish.addweb, yas: Manage K8s API Services
    
yas’s picture

Status: Reviewed & tested by the community » Fixed
yas’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.