screenshot-20200130-a.png
screenshot-20200130-b.png
screenshot-20200130-c.png
screenshot-20200130-d.png
screenshot-20200130-e.png
screenshot-20200130-f.png
screenshot-20200130-g.png
screenshot-20200130-h.png
screenshot-20200130-i.png

CommentFileSizeAuthor
#6 3109011-6.patch54.45 KBjigish.addweb
#4 screenshot-20200130-i.png839.14 KByas
#4 screenshot-20200130-h.png773.32 KByas
#4 screenshot-20200130-g.png882.37 KByas
#4 screenshot-20200130-f.png878.99 KByas
#4 screenshot-20200130-e.png809.73 KByas
#4 screenshot-20200130-d.png885.08 KByas
#4 screenshot-20200130-c.png847.3 KByas
#4 screenshot-20200130-b.png824.8 KByas
#4 screenshot-20200130-a.png914.03 KByas
#3 3109011-3.patch54.19 KBjigish.addweb
#2 3109011-2.patch53.29 KBjigish.addweb

Comments

jigish.addweb created an issue. See original summary.

jigish.addweb’s picture

jigish.addweb commented
Status: Active » Needs review
StatusFileSize
new 3109011-2.patch53.29 KB
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3109011-3.patch54.19 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new screenshot-20200130-a.png914.03 KB
new screenshot-20200130-b.png824.8 KB
new screenshot-20200130-c.png847.3 KB
new screenshot-20200130-d.png885.08 KB
new screenshot-20200130-e.png809.73 KB
new screenshot-20200130-f.png878.99 KB
new screenshot-20200130-g.png882.37 KB
new screenshot-20200130-h.png773.32 KB
new screenshot-20200130-i.png839.14 KB

@jigishaddweb

Thank you for providing the patch. I tested it and looks good to me. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@jigishaddweb

I found the coding standard violation error:

$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md /var/www/html/web/modules/contrib/cloud/

FILE: /var/www/html/web/modules/contrib/cloud/modules/cloud_service_providers/k8s/src/Service/K8sServiceInterface.php
---------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
 586 | WARNING | Line exceeds 80 characters; contains 81 characters
---------------------------------------------------------------------------------------------------------------------

Could you please fix it? And please run the command before you upload the patch:

phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md /var/www/html/web/modules/contrib/cloud/

PS The wording api should be API

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3109011-6.patch54.45 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review

@yas

Thank you for testing the patch.

I have fixed coding standard violation error.

Please test new patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@jigishaddweb

Thank you for the update. It looks good to me. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

  • yas committed fbe4ec7 on 8.x-1.x authored by jigish.addweb 
    Issue #3109011 by jigish.addweb, yas: Manage K8s Cluster Role Bindings

  • yas committed 06d690a on 8.x-2.x authored by jigish.addweb 
    Issue #3109011 by jigish.addweb, yas: Manage K8s Cluster Role Bindings
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3095569: Composer could not parse version constraint / could not load package (2)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.