It just took me a few minutes to figure out why I got the error "default.settings.php" should not be changed during installation.
I *moved* default.settings.php to settings.php that was my mistake. I think the error message could be nicer, I wondered what changes I had done to settings.php and it took me a while to get that the default file still has to be present.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | default-settings-php-error-messag.png | 12.68 KB | ifrik |
| #3 | 3108803-3.patch | 856 bytes | k4v |
Comments
Comment #2
k4v commentedComment #3
k4v commentedComment #4
k4v commented"in any way" was a bit misleading, as the installer does not check the files content.
Comment #5
k4v commentedComment #6
k4v commentedComment #7
gogowitsch commentedMy colleagues and I ran into this error multiple times for the same reason.
The patch looks fine to me. I tested it locally and the message is displayed correctly when using the HTTP-based installer.
Comment #8
c-logemannRemoved tag "GlobalContributionWeekend2020" to reduce confusion. See global event page.
Comment #9
ifrikThanks kv4 for this UX fix - and for taking the time to fix an issue that developers won't even notice because once you know how it works you don't see the error messages anymore.
Comment #10
alexpottCredited @ifrik and @Gogowitsch for testing the patch locally.
Committed and pushed f7d7c625f8 to 9.0.x and e6f3c8d035 to 8.9.x. Thanks!