Drupal 9 deprecation status issue:

Parameter $alias_manager of method Drupal​\​share_everywhere​\​Plugin​\​Block​\​ShareEverywhereBlock::__construct() has typehint with deprecated class Drupal​\​Core​\​Path​\​AliasManager. Deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Use Drupal​\​path_alias​\​AliasManager instead.

Parameter $alias_manager of method Drupal​\​share_everywhere​\​ShareEverywhereService::__construct() has typehint with deprecated class Drupal​\​Core​\​Path​\​AliasManager. Deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Use Drupal​\​path_alias​\​AliasManager instead.

Comments

srijeeta created an issue. See original summary.

srijeeta’s picture

StatusFileSize
new3.55 KB

Deprecation status fixes added.

malaynayak’s picture

Status: Active » Needs review
c-logemann’s picture

Issue tags: -GlobalContributionWeekend2020

Remove tag to reduce confusion. "ContributionWeekend2020“ is the "official" tag suggested on global event page.

srijeeta’s picture

malaynayak’s picture

Status: Needs review » Reviewed & tested by the community

patch #2 looks good to me.

arpad.rozsa’s picture

Status: Reviewed & tested by the community » Needs work

As you can see from the tests, the following change is not enough:

-core: 8.x
+core_version_requirement: ^8 || ^9

The test on D8.7 fails, since the path_alias module was added in D8.8, before that these changes won't work and breaks the module. We can't support versions before D8.8 and the code above should be core_version_requirement: ^8.8 || ^9. Also add the same requirement to composer.json.

Not sure why the D9 test didn't finish, but it was months ago so it probably should work now, But a change also needed for D9, because the path_alias module is optional, it might not be installed on every site by default.
So please add the path_alias as a dependency of share_everywhere in info.yml.

tdnshah’s picture

Assigned: srijeeta » tdnshah
tdnshah’s picture

StatusFileSize
new558 bytes
new3.89 KB

Tested in Drupal 8.8 and 9.1.0-dev works well with #9 patch.

Thank you

tdnshah’s picture

StatusFileSize
new3.9 KB
new212 bytes

Composer json updated to support ^9.1 version of core.

tdnshah’s picture

Assigned: tdnshah » Unassigned
Status: Needs work » Needs review
kristen pol’s picture

Category: Support request » Feature request
Issue tags: -Drupal 8, -Drupal 9 +Drupal 9 compatibility
aspilicious’s picture

Status: Needs review » Needs work

+ "require": {
+ "drupal/core": "^8.8 || ^9.1"
+ }
+}

is incorrect and not needed. I think you can revert the composer.json part.
If not than 9.1 should be 9.0.

tdnshah’s picture

@aspilicious, I added the composer part as per the suggestion given in #7 will it work as it is mentioned that the module won't be supporting Drupal 8.7 as it is dependent on path_alias hence would like to know can we remove composer part or its is must and required

aspilicious’s picture

Than you need to change 9.1 to 9.0

tdnshah’s picture

Status: Needs work » Needs review
StatusFileSize
new214 bytes
new3.9 KB

Update drupal core version to ^9.0 from ^9.1 as in patch #9 in composer json file.

I am not understanding y the test is failing with PHP 7.4 & MySQL 5.7, D9.0, Please help

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

It's failing because this patch needs to be committed first.
So this is good to go. After the commit, the maintainer can start a test to verify it works.

arpad.rozsa’s picture

Version: 8.x-1.x-dev » 2.x-dev
Status: Reviewed & tested by the community » Fixed

Thanks everyone for helping in this issue. In the end I ended up creating a new branch for Drupal 9 to use semantic versioning. In the meantime I was also working on some changes, so the patches are outdated now e.g. I removed the path alias manager from the ShareEverywhereService.

The 8.x-1.x branch will only work with Drupal 8 and you have the new 2.x branch with Drupal 9 support as well as Drupal ^8.8.
People should update to 2.0.0, if they use use drupal 8.8 at least.

arpad.rozsa’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.