Closed (fixed)
Project:
Share Everywhere
Version:
2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
25 Jan 2020 at 10:37 UTC
Updated:
19 Jun 2020 at 13:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
srijeeta commentedDeprecation status fixes added.
Comment #3
malaynayak commentedComment #4
c-logemannRemove tag to reduce confusion. "ContributionWeekend2020“ is the "official" tag suggested on global event page.
Comment #5
srijeeta commentedComment #6
malaynayak commentedpatch #2 looks good to me.
Comment #7
arpad.rozsa commentedAs you can see from the tests, the following change is not enough:
The test on D8.7 fails, since the
path_aliasmodule was added in D8.8, before that these changes won't work and breaks the module. We can't support versions before D8.8 and the code above should becore_version_requirement: ^8.8 || ^9. Also add the same requirement tocomposer.json.Not sure why the D9 test didn't finish, but it was months ago so it probably should work now, But a change also needed for D9, because the
path_aliasmodule is optional, it might not be installed on every site by default.So please add the
path_aliasas a dependency of share_everywhere ininfo.yml.Comment #8
tdnshah commentedComment #9
tdnshah commentedTested in Drupal 8.8 and 9.1.0-dev works well with #9 patch.
Thank you
Comment #10
tdnshah commentedComposer json updated to support ^9.1 version of core.
Comment #11
tdnshah commentedComment #12
kristen polComment #13
aspilicious commented+ "require": {
+ "drupal/core": "^8.8 || ^9.1"
+ }
+}
is incorrect and not needed. I think you can revert the composer.json part.
If not than 9.1 should be 9.0.
Comment #14
tdnshah commented@aspilicious, I added the composer part as per the suggestion given in #7 will it work as it is mentioned that the module won't be supporting Drupal 8.7 as it is dependent on path_alias hence would like to know can we remove composer part or its is must and required
Comment #15
aspilicious commentedThan you need to change 9.1 to 9.0
Comment #16
tdnshah commentedUpdate drupal core version to ^9.0 from ^9.1 as in patch #9 in composer json file.
I am not understanding y the test is failing with PHP 7.4 & MySQL 5.7, D9.0, Please help
Comment #17
aspilicious commentedIt's failing because this patch needs to be committed first.
So this is good to go. After the commit, the maintainer can start a test to verify it works.
Comment #18
arpad.rozsa commentedThanks everyone for helping in this issue. In the end I ended up creating a new branch for Drupal 9 to use semantic versioning. In the meantime I was also working on some changes, so the patches are outdated now e.g. I removed the path alias manager from the ShareEverywhereService.
The 8.x-1.x branch will only work with Drupal 8 and you have the new 2.x branch with Drupal 9 support as well as Drupal ^8.8.
People should update to 2.0.0, if they use use drupal 8.8 at least.
Comment #19
arpad.rozsa commented